[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: kdeui/kdialog margin size
From:       Richard Moore <rich () ipso-facto ! freeserve ! co ! uk>
Date:       2001-05-18 14:17:54
[Download RAW message or body]



Ralf Nolden wrote:
> 
> Hi,
> 
> while fixing up modules in kcontrol I noticed that the margin size used
> by KDialog is different than the one designer uses. As dialogs are
> currently mixed ones done with designer in one module and with KDialog
> methods in others, we need to stay consistent with the designer ones
> IMHO. What needs to be changed is

No, no, no - what needs to be changed is the usage of designer.
A margin in of 11 is *way* too big, plus you will break any existing
manual layouts.

Rich.

> 
> /kdelibs/kdeui/kdialog.cpp:
> 
> int KDialog::mMarginSize = 6;
> int KDialog::mSpacingSize = 6;
> 
> so that mMarginSize is 11. I'll do a test this afternoon for all dialogs
> with stulle in the internet cafe to see if we find some other problems
> if this is changed, then I'll change this if it's ok and call
> KNotify::Zogje() :-)
> 
> Ralf
> --
> Finally, even I have to admit that being myself was the best thing
> that ever could have happened to me. - Le Grand Charmeur
> 
> **********************************
> Ralf Nolden
> 
> The KDevelop Project
> http://www.kdevelop.org
> 
> nolden@kde.org
> rnolden@kdevelop.org
> **********************************

[prev in list] [next in list] [prev in thread] [next in thread]