[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Need help with kwin maintainance
From:       Lubos Lunak <l.lunak () sh ! cvut ! cz>
Date:       2001-05-09 20:27:47
[Download RAW message or body]

Dne st 9. květen 2001 21:34 mosfet napsal(a):
> Yes, I haven't really worked on this at all either.
>
> Gallium, you doing anything? ;-)
>
> Matthias Ettrich wrote:
> > Hello guys,
> >
[snip]

 Mosfet, you're the author of the default kwin style, aren't you ? Could you 
( or whoever else ) please tweak it's paintEvent() a bit so it doesn't leave 
"holes" when you apply the following patch ? Just apply it and set kdesktop 
background e.g. to orange, you'll see it. On slower machines, without 
NoBackground the decorations flicker quite noticeably sometimes, and since 
this is the default, it would be IMHO worth improving it. Just look at 
Gallium's styles, they all use NoBackground and they don't flicker. I've 
already reduced kwin flickering a bit, but I'm not a big friend with 
QPainter. The same applies for KDE1 and Laptop styles.
 I also wonder why the sticky button doesn't look like the others ( it's dark 
blue here like the titlebar unlike the grey maximize etc. buttons ). Now that 
there's a kcontrol module for specifying the button positions, the default 
style would look ugly if someone moved the sticky button to the right ( 
assuming that this style would follow the kcontrol settings which it doesn't 
do yet ).

--- kdedefault.cpp.bak  Tue Mar 13 02:01:34 2001
+++ kdedefault.cpp      Thu Apr 19 10:52:09 2001
@@ -372,6 +372,7 @@ KDEDefaultClientButton::KDEDefaultClient
                            const unsigned char *bitmap)
     : QToolButton(parent, name)
 {
+    setBackgroundMode( NoBackground );
     isMouseOver = false;
     client = parent;
     setFixedSize(16, 16);

 
 Lubos Lunak
--
 l.lunak@email.cz ; l.lunak@kde.org
 http://dforce.sh.cvut.cz/~seli

[prev in list] [next in list] [prev in thread] [next in thread]