[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Taskbar and panel broken stuff
From:       mosfet <mosfet () mandrakesoft ! com>
Date:       2001-01-29 14:55:58
[Download RAW message or body]

On Saturday 27 January 2001 12:30 pm, mosfet wrote:
> On Saturday 27 January 2001 02:59 am, Matthias Elter wrote:
> > On Friday 26 January 2001 03:14, mosfet wrote:
> > > Okay, I updated because I'm doing some style stuff and noticed some
> > > massive taskbar and panel breakage:
> > >
> > > 1) The taskbar no longer uses the proper KStyle routine -
> > > drawKickerTaskButton. This breaks several styles, including highcolor.
> >
> > The taskbar is using QStyle::drawPanel instead. We should mark
> > KStyle::drawkickerTaskButton obsolete.
>
> Why? We need that if we want themes to be able to theme the taskbar... At
> the least you should use drawBevelButton and not drawPanel, but having a
> routine specifically for the taskbar buttons is nice and I don't see any
> justification to remove it. Why make themes and styles less flexible?
>

Any answer to this? If not I'm going to switch it back to being themeable... 
it's only one line. You have no idea how crappy it looks to have a Aqua 
themed panel with ugly non-pixmapped rectangular task buttons that don't 
match the rest of the UI. I'm actually curious about why you thought it was 
obselete - it's certainly not and is being used by several styles. As a 
matter of fact, once KDE III gets started I'm thinking of adding new routines 
for the Pager buttons and the Desktop menu. Everything default in the UI 
needs to be themeable.

As a side note - drawPanel is wrong because this is used to draw a lot of 
other things in the UI (like the pages of tabs) that certainly shouldn't look 
like a task button, and drawBevelButton is wrong because it's also used to 
draw things like headers and I could see why people (including me ;-) would 
like the two to look different. This is why I added the proper routine months 
ago ;-)


> > > 2) The taskbar no longer propagates mouse events when there isn't a
> > > button, so at least on my system you no longer can configure the panel
> > > with right clicking in the empty space in the taskbar - which takes up
> > > all available space ;-) You have to use the menus.
> >
> > Hm, right. I think the Corel changes to make the panel scrollable broke
> > this. I will have a look.
>
> Cool.
>
> > > 3) Background pixmaps for the panel have lines in them that shouldn't
> > > be there.
> >
> > Eh?
>
> Well, I usually use a 64x64 gradient as the panel's background pixmap, and
> now it has vertical lines in it that shouldn't be there.

[prev in list] [next in list] [prev in thread] [next in thread]