[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    QIconView crash workaround
From:       Carsten Pfeiffer <carpdjih () cetus ! zrz ! TU-Berlin ! DE>
Date:       2000-10-14 15:09:27
[Download RAW message or body]

Hi,

Christian Gebauer notified me of a little bug in kfile, which turned out
to be a bug in QIconView. It crashes, when you shift-click in the
iconview, when there is no currenItem() (in Extended selection mode).

Now I just committed a workaround in kfile, but I think it might be safer
to put it into KIconView directly.

Should I commit (and revert the workaround in kfile)?

Cheers,
Carsten Pfeiffer

["kiconview.patch" (text/plain)]

Index: kiconview.cpp
===================================================================
RCS file: /home/kde/kdelibs/kdeui/kiconview.cpp,v
retrieving revision 1.29
diff -u -p -B -w -r1.29 kiconview.cpp
--- kiconview.cpp	2000/10/12 08:55:21	1.29
+++ kiconview.cpp	2000/10/14 15:04:44
@@ -285,6 +285,12 @@ void KIconView::contentsMousePressEvent(
     blockSignals( block );
   }
 
+  // QIconView (2.2.1) bug workaround!
+  if ( e->state() & ShiftButton && !currentItem() ) {
+      setCurrentItem( firstItem() );
+  }
+  // end QIconView bug workaround
+  
   QIconView::contentsMousePressEvent( e );
 }
 


[prev in list] [next in list] [prev in thread] [next in thread]