[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: kio&kcontrol patch against hardcoded subdir paths
From:       David Faure <david () mandrakesoft ! com>
Date:       2000-09-05 9:14:41
[Download RAW message or body]

On Tue, 05 Sep 2000, Waldo Bastian wrote :
>On Mon, 04 Sep 2000, David Faure wrote:
>> > kcontrol looks for its items in "Settings/". But if you use the menu
>> editor to move that as a subdir of something else, or if you work
>> for a distribution that likes things named another way :), then hardcoding
>> a relative path looks no good at all.
>>
>> The attached patch introduces a new notion: the one of base group.
>>
>> A key in the .directory is added in the config file (X-KDE-BaseGroup),
>> so that it gets moved with the directory. KServiceGroup provides a method
>> for finding the group.
>>
>> Used by kcontrol for the Settings group, and by kscreensaver for the
>> System/ScreenSavers group.
>
>I don't like the use of magic numbers for stuff like this why not use a 
>string and give it a names like "settings" and "screensavers".

Yup, thought about that.
Ok, will do.

>The other thing that I don't like about it is that you do a linear search for 
>these items. If you add an index for "basegroups" you can find them much 
>faster.

Thought about that too, but I'm lost in the new ksycoca design ;-)
Where would I do that ?

-- 
David FAURE, david@mandrakesoft.com, faure@kde.org
http://home.clara.net/faure/, http://www.konqueror.org/
KDE, Making The Future of Computing Available Today
See http://www.kde.org/kde1-and-kde2.html for how to set up KDE 2

[prev in list] [next in list] [prev in thread] [next in thread]