[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: mpeglib cdrom patch....
From:       Stefan Westerfeld <stefan () space ! twc ! de>
Date:       2000-08-31 10:46:37
[Download RAW message or body]

Hi!

On Thu, Aug 31, 2000 at 02:19:05AM -0700, Alex Zepeda wrote:
> On Thu, Aug 31, 2000 at 01:35:20AM +0200, Martin Vogt wrote:
> > >>, Im against this. Maybe for KDE 2.1.
> > >> But what may be an option is to pass a command line switch, like
> > >> --enable-mpeglib as an override but not as default.
> > 
> > >Well it would be nice to move this junk to another module if it's not
> > >useable.
> > 
> > If you think it should be removed from kdemultimedia
> > continue your discussion there.
> 
> Well I'd rather see it actually compile (errr artsplug that is).  But if
> it can't be made to work, then, yes I'd pursue moving it from
> kdemultimedia.

Well, there is (almost) nothing that can't be made work, it just needs
somebody doing it (and obviously you volunteered ;). Its like artsd & AIX.
If anybody has a patch for sound output with the native AIX driver, I'd
happily include it for KDE2.0, but I can't do one myself (no AIX here ;).

I also think that if it compiles and works fine on FreeBSD (or whatever else),
then there is not much that speaks against enabling it. Nobody will ever try
to debug the remaining problems if there isn't at least a version that
somewhat works and installs ;)

As for why mpeglib_artsplug doesn't compile... I've attached a small
patch you can try out (based on the ... _defaultPortsIn() needs a final
overrider error message you posted recently). I am not sure if it does the
trick and if that error message is still what keeps you from compiling
mpeglib_artsplug.

   Cu... Stefan
-- 
  -* Stefan Westerfeld, stefan@space.twc.de (PGP!), Hamburg/Germany
     KDE Developer, project infos at http://space.twc.de/~stefan/kde *-         

["alex.diff" (text/plain)]

Index: decoderBaseObject.idl
===================================================================
RCS file: /home/kde/kdemultimedia/mpeglib_artsplug/decoderBaseObject.idl,v
retrieving revision 1.1.1.1
diff -b -u -p -r1.1.1.1 decoderBaseObject.idl
--- decoderBaseObject.idl	2000/07/04 19:37:00	1.1.1.1
+++ decoderBaseObject.idl	2000/08/31 10:38:13
@@ -3,40 +3,31 @@
 
 
 
-interface DecoderBaseObject : Arts::PlayObject
+interface DecoderBaseObject : Arts::PlayObject, Arts::SynthModule
 {
 
-
-
 };
 
 
-interface MP3PlayObject : DecoderBaseObject , Arts::SynthModule
+interface MP3PlayObject : DecoderBaseObject
 {
   out audio stream left,right;
-
 };
 
 
-interface WAVPlayObject : DecoderBaseObject , Arts::SynthModule
+interface WAVPlayObject : DecoderBaseObject
 {
   out audio stream left,right;
-
 };
 
 
-interface MPGPlayObject : DecoderBaseObject , Arts::SynthModule
+interface MPGPlayObject : DecoderBaseObject
 {
   out audio stream left,right;
-
 };
 
 
-interface OGGPlayObject : DecoderBaseObject , Arts::SynthModule
+interface OGGPlayObject : DecoderBaseObject
 {
   out audio stream left,right;
-
 };
-
-
-


[prev in list] [next in list] [prev in thread] [next in thread]