[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: problem compiling kcmlocale
From:       Waldo Bastian <bastian () kde ! org>
Date:       2000-06-15 17:17:21
[Download RAW message or body]

On Thu, 15 Jun 2000, Bernd Gehrmann wrote:
> On Thu, 15 Jun 2000, David Faure wrote:
> > On Wed, Jun 14, 2000 at 10:08:56PM -0400, pbrown@redhat.com wrote:
> > > there is a problem compiling the locale module for kcontrol.  Some of
> > > the classes inherit directly from KLocale in order to manipulate
> > > settings.  Seems these settings went from protected to private
> > > recently.
> > >
> > > Changing this module is going to require some extensive work, because
> > > there are no set* methods in KLocale either.
> > >
> > > Was this intended?  What will be the recommended solution, so I don't
> > > go down the wrong path?
> >
> > Bernd G. was a bit overzealous on this one, apparently :-)
> > Can you make private only what should be private ? Generally many things
> > should be protected instead of private, IMHO, to allow
> > reimplementations...
>
> Reimplementations require a well-defined and documented API.
> Undocumented hacks are not a replacement for an API.

Breaking code is unacceptable. It's great if you make a nice API, but you 
can't just change stuff without fixing what it breaks. 

Cheers,
Waldo
-- 
Make way, KDE/Linux is coming to a desktop near you!

[prev in list] [next in list] [prev in thread] [next in thread]