[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: qaction mods
From:       David Faure <david () mandrakesoft ! com>
Date:       2000-02-28 15:33:04
[Download RAW message or body]

AFAIK it's ours for now, until Qt (perhaps) includes it.

This means : in theory we can do whatever we want and nobody
will care for now, but think about what will happen if it ever
gets back into Qt. We probably want to keep the current
QAction/KAction split, for the day this happens.

Otherwise, we'll have a KDE-only class, not inheriting the Qt one,
and we all know what it did for KMenuBar, for instance.
(The KDE code remaining in KAction, the Qt one in QAction, any 
feature that the future QAction will provide, KAction will get it).

This being said, it looks like we should do all we want to do
in KAction itself, even if it duplicates code.
For once, duplicating seems like a better idea than merging...

Just my 2 cents.


On Mon, Feb 28, 2000 at 08:42:51AM -0700, Kurt Granroth wrote:
> Okay, what is the status of QAction?  Is it going to be folded into
> KDE now that it's been excluded from Qt 2.1?  To get more to the
> point, can we start modifying it?
> 
> I ask mostly because I want to make the actions a little more
> intelligent about icons sizes but it's very hard to do at the KAction
> level without duplicating a lot of QAction code.  It would be very
> nice to modify QAction directly...
> 
> Of course, then QAction would be KDE dependent and it wouldn't make
> sense to have a separate QAction and KAction anymore.
> 
> So back to my question: what is the status of QAction?
> -- 
> Kurt Granroth            | http://www.granroth.org
> KDE Developer/Evangelist | SuSE Labs Open Source Developer
> granroth@kde.org         | granroth@suse.com
>            KDE -- Putting a Friendly Face on Unix

-- 
David FAURE
david@mandrakesoft.com, faure@kde.org
http://home.clara.net/faure/
KDE, Making The Future of Computing Available Today

[prev in list] [next in list] [prev in thread] [next in thread]