[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Konqueror bug - can I fix???
From:       Simon Hausmann <shaus () helios ! med ! Uni-Magdeburg ! DE>
Date:       2000-01-28 23:04:35
[Download RAW message or body]



On Fri, 28 Jan 2000, Dawit Alemayehu wrote:

> On Fri, 28 Jan 2000, Simon Hausmann wrote:
> > On Fri, 28 Jan 2000, David Faure wrote:
> > 
> > > On Fri, Jan 28, 2000 at 12:29:55PM -0700, Robert Williams wrote:
> > > > The bug:
> > > > 
> > > > Open a text file (or any viewer) in konqueror and the location of the
> > > > file stays in the title bar no matter what.  I can fix this but I am not
> > > > sure where to start looking.  Is this in /libkonq?  or /konqueror?
> > > 
> > > The title bar or the location bar, you mean ?
> > > 
> > > I guess the location bar, no ?
> > > I thought Simon fixed that...
> > 
> > I thought so, too ;-)
> > 
> > Well, I can't hack right now as I'm recompiling :(
> > 
> > > Look in konq_mainview.cc, which holds the location bar.
> > 
> > Yep.
> > Robert, have a look at KonqMainView::openURL(), somewhere around line
> > #328. I think the locationbar's text is set too "early" (as openView(),
> > which is called in this case as the iconview provides the servicetype,
> > might fail)). .. although openView() "resets" the locationbar text when it
> > fails.
> > 
> > I guess moving the setEditText() call into the "else" case ( just right
> > before the KonqRun instance is allocated) , or even removing the call,
> > should fix it.
> > 
> > Ciao,
> >  Simon
> 
> Well here is a patch.  I am not sure if this works though because I currently
> cannot compile kdebase :((  It looks like someone made changes to QIconView
> and forgot to commit.
>
> BTW,  what about the setLocationBarURL( view, url.decodedURL() ); sent to
> childviews.  Doesn't it need to be changed as well ??

Well, it seems Robert meant the title bar (not the locationbar :-)

And I just checked the current code, and it works perfectly fine here
(opening a text file with kedit keeps the directory URL in the locationbar
-> the "failback" code in ::openView() resets the URL correctly)

:-)

Ciao,
 Simon

[prev in list] [next in list] [prev in thread] [next in thread]