[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Konqueror bug - can I fix???
From:       Dawit Alemayehu <adawit () earthlink ! net>
Date:       2000-01-28 22:47:07
[Download RAW message or body]

On Fri, 28 Jan 2000, Simon Hausmann wrote:
> On Fri, 28 Jan 2000, David Faure wrote:
> 
> > On Fri, Jan 28, 2000 at 12:29:55PM -0700, Robert Williams wrote:
> > > The bug:
> > > 
> > > Open a text file (or any viewer) in konqueror and the location of the
> > > file stays in the title bar no matter what.  I can fix this but I am not
> > > sure where to start looking.  Is this in /libkonq?  or /konqueror?
> > 
> > The title bar or the location bar, you mean ?
> > 
> > I guess the location bar, no ?
> > I thought Simon fixed that...
> 
> I thought so, too ;-)
> 
> Well, I can't hack right now as I'm recompiling :(
> 
> > Look in konq_mainview.cc, which holds the location bar.
> 
> Yep.
> Robert, have a look at KonqMainView::openURL(), somewhere around line
> #328. I think the locationbar's text is set too "early" (as openView(),
> which is called in this case as the iconview provides the servicetype,
> might fail)). .. although openView() "resets" the locationbar text when it
> fails.
> 
> I guess moving the setEditText() call into the "else" case ( just right
> before the KonqRun instance is allocated) , or even removing the call,
> should fix it.
> 
> Ciao,
>  Simon

Well here is a patch.  I am not sure if this works though because I currently
cannot compile kdebase :((  It looks like someone made changes to QIconView
and forgot to commit.

BTW,  what about the setLocationBarURL( view, url.decodedURL() ); sent to
childviews.  Doesn't it need to be changed as well ??

Regards,
Dawit A.
["konq_mainview.diff" (text/x-c++)]

Index: konq_mainview.cc
===================================================================
RCS file: /home/kde/kdebase/konqueror/konq_mainview.cc,v
retrieving revision 1.353
diff -u -r1.353 konq_mainview.cc
--- konq_mainview.cc	2000/01/24 12:28:55	1.353
+++ konq_mainview.cc	2000/01/28 22:51:36
@@ -324,21 +324,22 @@
   }
   else
   {
-    if ( m_combo )
-      m_combo->setEditText( url.decodedURL() );
-
     if ( !serviceType.isEmpty() )
     {
       if ( !openView( serviceType, url, 0L ) )
       {
         kDebugInfo( 1202, "%s", QString("Creating new KRun for %1").arg(url.url()).latin1() );
         (void)new KRun( url.url() );
+        if ( m_combo )
+            m_combo->setEditText( url.decodedURL() );
       }
     }
     else
     {
       kDebugInfo( 1202, "%s", QString("Creating new konqrun for %1").arg(url.url()).latin1() );
       (void) new KonqRun( this, 0L, url.url(), 0, false, true );
+      if ( m_combo )
+        m_combo->setEditText( url.decodedURL() );
     }
   }
 


[prev in list] [next in list] [prev in thread] [next in thread]