[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: KMessageBox::questionYesNo change
From:       Antonio Larrosa <antlarr () arrakis ! es>
Date:       1999-11-29 6:41:43
[Download RAW message or body]

David Faure wrote:
> 
> On Sun, Nov 28, 1999 at 02:10:07PM +0000, Stephan Kulow wrote:
> > David Faure wrote:
> > >
> > > On Sun, Nov 28, 1999 at 11:47:13AM +0000, Stephan Kulow wrote:
> > > > Antonio Larrosa wrote:
> > > > >
> > > > >
> > > > > Opinions ?
> > > >
> > > > Another point: how would the message box look like if I'm going to
> > > > delete 6000 files?
> > >
> > > I thought of displaying the total number and the first 10 items and "...".
> > > Antonio, is this possible ?
> > >
> > But how you handle this exception is very application specific no?
> > I mean you would write "want you to delete the %1 files:" + list
> > but would write something completly different in other uses
> 
> I definitely agree that this should be in konqueror, not in kdeui.
> 

Perhaps you are right.
My main point for having it on the libs (and merging both methods, as
Stephan said, perhaps using QStringList as the last parameter), is that
the implementation is exactly as the original questionYesNo, but with an
additional QVBox and 4 more lines to add the QListBox. Copying it
(be it to Konqueror, or leaving it as another method of KMessageBox) is
code duplication impo (In my paranoiac opinion)
Also, each time an aplication wants some feedback from the user for an
action that operates on more than one item (files, appointments, whatever)
this message box should be used.

> > Greetings, Stephan
> > P.S. Didn't we want to discuss additions to the libraries _before_
> > doing them?
> >

Mea culpa, but I just thought that this was needed and implemented it,
as it couldn't break anything, was a binary compatible change, and it
worked right (I tested it), I thought there wouldn't be any negative
to commit it (anyway, we can remove it of course if you or David are
sure that it's better to move it to Konqueror)

Greetings,

Antonio Larrosa

[prev in list] [next in list] [prev in thread] [next in thread]