[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    1.x branch: kcmdisplay patch
From:       Harri Porten <porten () tu-harburg ! de>
Date:       1999-08-24 14:04:07
[Download RAW message or body]

Hi !

The random background code in kcmdisplay and kbgndwm has two or three
little bugs.

1.) kbgndwm uses DEFAULT_WALLPAPER which is defined as i18n("No
wallpaper"). kcmdisplay uses DEFAULT_WALLPAPER and i18n("No wallpaper")
directly. I don't think that the #define will be caugt by xgettext so
both programs won't work together correctly. Additionally, putting a
i18n'ed flag into a config file breaks switching languages.
The consequences of that problem aren't probably not that serious.

2.) If random mode is turned off the background manager remains in one
of the random states and ignores changes the wallpaper etc.

3.) If the random mode is activated and it's setup is opened the
randomMode flag is cleared again. 

The following patch fixes at least the last problem. It's success has
been confirmed by the person reporting bug #1768. Matt hasn't answered
my mail, yet, so I would like to apply the patch if no ones finds any
fault in it.

Harri.
["backgnd.diff" (text/plain)]

Index: backgnd.cpp
===================================================================
RCS file: /home/kde/kdebase/kcontrol/display/backgnd.cpp,v
retrieving revision 1.43.2.4
diff -u -r1.43.2.4 backgnd.cpp
--- backgnd.cpp	1999/08/23 07:43:32	1.43.2.4
+++ backgnd.cpp	1999/08/24 13:13:57
@@ -2009,6 +2009,7 @@
   picturesConfig.writeEntry( "InOrder", orderButton->isChecked() );
   picturesConfig.writeEntry( "UseDir", dirCheckBox->isChecked() );
   picturesConfig.writeEntry( "Directory", dirLined->text() );
+  picturesConfig.writeEntry( "RandomMode", true );
 
   hide();
   
@@ -2016,6 +2017,7 @@
 
   kb->rnddlg = 0L;
   kb->random = 0;
+  kb->randomMode = true;
   kb->randomSetupButton->setEnabled( true );
   kb->wpModeCombo->setEnabled( false );
 }


[prev in list] [next in list] [prev in thread] [next in thread]