[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Changes to DialogBase and KAboutDialog
From:       Mirko Sucker <mirko.sucker () unibw-hamburg ! de>
Date:       1999-07-11 22:02:22
[Download RAW message or body]

"Dirk A. Mueller" wrote:

> Mirko Sucker <mirko.sucker@unibw-hamburg.de> wrote:
>
> > I added kaboutdialogtest.cpp to kdelibs/kdetest, with two image files
> > that show the features of the classes.
>
> Nice work!
>
> But wouldn't it be more logical to put the i18n("Current
> Maintainer")/i18n("Initial developer") calls into the lib rather than
> adding it as an parameter to setAuthor()/setMaintainer() ?

No, since the text is intended to be different from "Current maintainer".
Why not allow the developers to choose their own text? It is easy to put
it
in as a kind of default text, of course, what would you (all) say?

> In addition, the kdoc-umentation doesn't seem to be up to date, the 4th
> parmeter is called "work" there ?!

I am currently working on it.

> btw, the comment "requires Qt 1.4" is already obsolete, isn't it ? ;)

At least outdated.
Greetings,
--Mirko.

--
Denn der  Mensch  liebt und ehrt den  Menschen,  solange er ihn
nicht zu beurteilen vermag, und die Sehnsucht ist ein Erzeugnis
mangelhafter Erkenntnis. (Thomas Mann)

[prev in list] [next in list] [prev in thread] [next in thread]