[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: KSvg in kdereview
From:       Ben Cooksley <bcooksley () kde ! org>
Date:       2023-06-20 18:44:13
Message-ID: CA+XidOF0fswHEUUtEG-5hF=uTi4QrLtgsEGaPeOT_H411KM9hg () mail ! gmail ! com
[Download RAW message or body]

Hi all,

Sysadmin has just received a request to move this repository to Frameworks,
however after seeing some of the comments raised here regarding the
repository I took a look myself to see if they had been corrected.

At this time CI is still broken in KSvg, for both platforms - something
that was mentioned in an earlier email here.
This does not inspire confidence that the code is up to scratch.

I've therefore declined to move it to Frameworks at this time.

Would be appreciated, given this is looking to be promoted to Frameworks,
if people could please have a further look at this repository and comment
as appropriate.

Thanks,
Ben

On Wed, Jun 14, 2023 at 9:12 PM Marco Martin <notmart@gmail.com> wrote:

> Hi all,
> Some time has passes, and changes have been done in the repo to
> address some of the points.
> Now there are review requests in plasma-framework which depends on
> this repo (and accompanying plasma-workspace, plasma-desktop etc)
> It would probably be better to have this in frameworks to have the
> rest depending from it?
>
> On Thu, Apr 20, 2023 at 10:25 AM Marco Martin <notmart@gmail.com> wrote:
> >
> > Hi all,
> > A part of plasma-framewrok, which is the one to do SVG-based themes,
> > has now been splitted in a standalone library which is intended to be
> > a new framework in KF6 (all usages of the plasma-framework version
> > will be ported once this officially lands, and then those classes will
> > be removed)
> > The repo for now lives in
> > https://invent.kde.org/libraries/plasmasvg
> >
> > In the end it will be renamed in ksvg
> >
> > Comments? reviews?
> >
> >
> > --
> > Marco Martin
>
> --
> Marco Martin
>

[Attachment #3 (text/html)]

<div dir="ltr"><div>Hi all,</div><div><br></div><div>Sysadmin has just received a \
request to move this repository to Frameworks, however after seeing some of the \
comments raised here regarding the repository I took a look myself to see if they had \
been corrected.</div><div><br></div><div>At this time CI is still broken in KSvg, for \
both platforms - something that was mentioned in an earlier email \
here.</div><div>This does not inspire confidence that the code is up to \
scratch.</div><div><br></div><div>I&#39;ve therefore declined to move it to \
Frameworks at this time.</div><div><br></div><div>Would be appreciated, given this is \
looking to be promoted to Frameworks, if people could please have a further look at \
this repository and comment as \
appropriate.</div><div><br></div><div>Thanks,</div><div>Ben</div><br><div \
class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Jun 14, 2023 at \
9:12 PM Marco Martin &lt;<a \
href="mailto:notmart@gmail.com">notmart@gmail.com</a>&gt; wrote:<br></div><blockquote \
class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid \
rgb(204,204,204);padding-left:1ex">Hi all,<br> Some time has passes, and changes have \
been done in the repo to<br> address some of the points.<br>
Now there are review requests in plasma-framework which depends on<br>
this repo (and accompanying plasma-workspace, plasma-desktop etc)<br>
It would probably be better to have this in frameworks to have the<br>
rest depending from it?<br>
<br>
On Thu, Apr 20, 2023 at 10:25 AM Marco Martin &lt;<a \
href="mailto:notmart@gmail.com" target="_blank">notmart@gmail.com</a>&gt; wrote:<br> \
&gt;<br> &gt; Hi all,<br>
&gt; A part of plasma-framewrok, which is the one to do SVG-based themes,<br>
&gt; has now been splitted in a standalone library which is intended to be<br>
&gt; a new framework in KF6 (all usages of the plasma-framework version<br>
&gt; will be ported once this officially lands, and then those classes will<br>
&gt; be removed)<br>
&gt; The repo for now lives in<br>
&gt; <a href="https://invent.kde.org/libraries/plasmasvg" rel="noreferrer" \
target="_blank">https://invent.kde.org/libraries/plasmasvg</a><br> &gt;<br>
&gt; In the end it will be renamed in ksvg<br>
&gt;<br>
&gt; Comments? reviews?<br>
&gt;<br>
&gt;<br>
&gt; --<br>
&gt; Marco Martin<br>
<br>
-- <br>
Marco Martin<br>
</blockquote></div></div>



[prev in list] [next in list] [prev in thread] [next in thread]