[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: KSvg in kdereview
From:       Marco Martin <notmart () gmail ! com>
Date:       2023-04-24 9:21:33
Message-ID: CAD6_BoszZVor7Nv1voNcdPC2qsjLOrAaxoE-0RrmHYkt21S_Kw () mail ! gmail ! com
[Download RAW message or body]

On Sun, Apr 23, 2023 at 11:05 AM Albert Astals Cid <aacid@kde.org> wrote:
> > Comments? reviews?
>
> There's a few "TODO KF6" in the code, should those be addressed?

ok, I'll go over all of them in the review period

> Is the plan to make it less plasma-specific with the rename?
>
> i.e. the ImageSet constructor says
>
> Default constructor. It will be the global theme configured in plasmarc
>
> Is that wanted or not (i've no opinion, just asking to make sure since the
> rename seems to want to make it "less plasma").

hm, it looks like there is still some stray documentation which
doesn't completely  reflect truth anymore
(right now it doesn't use that config file anymore, it's up tp the
user's code) will correct

-- 
Marco Martin
[prev in list] [next in list] [prev in thread] [next in thread]