[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: CMake config & target challenges on moving to KF5 namespace; dir structure & API dox (Re: Submit
From: Stephen Kelly <steveire () gmail ! com>
Date: 2019-12-30 10:29:48
Message-ID: ee632f91-c020-b9a8-4a95-abe53789a25c () gmail ! com
[Download RAW message or body]
On 30/12/2019 08:55, Dominik Haumann wrote:
> Hi,
>
> Stephen Kelly <steveire@gmail.com <mailto:steveire@gmail.com>> schrieb
> am So., 29. Dez. 2019, 15:03:
>
>
> On 28/12/2019 23:30, Friedrich W. H. Kossebau wrote:
> > Why are you proposing to do a step back instead to the old
> state, which
> > everyone including you considered not that satisfying?
>
> Because it's a temporary situation. We still have a way forward in
> KF6
> (which will open in a few months).
>
>
> Generally, getting Grantlee into KF5 now also establishes the wrong
> precedent. Grantlee should be split into two repos each with a tier 1
> library (KF6::TextDocument and KF6::TextTemplate). The two are
> independent and have nothing to do with each other aside from
> authorship. That seems to be something you were objecting to, so I
> want
> to make sure that's something addressed on its own. The two KF6
> libraries will then follow the KF6 naming conventions etc.
>
>
> With my KTextEditor hat on: KF6:TextDocument implies somehow a link to
> QTextDocument or KF6:TextEditor, which both is incorrect, right?
QTextDocument is exactly what it's about, which makes the name
KF6::TextDocument fully appropriate and correct.
>
> Before starting this work, let's clarify whether we can find a more
> unique name (like KF6:GrantleeTextDocument).
>
The name I suggest is already correct.
> Since I haven't used Grantlee yet, I sm likely not the best person to
> find a better name ;)
Remember, Grantlee is a set of Frameworks (*Just like KF5/6*) which
happens to contain just TWO independent libraries.
Thanks,
Stephen.
[Attachment #3 (text/html)]
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<p><br>
</p>
<div class="moz-cite-prefix">On 30/12/2019 08:55, Dominik Haumann
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:CALi_srBu+W99wm2ksiZFsiabGJb-S6OKpCbpyNLwDi7p8EacpQ@mail.gmail.com">
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
<div dir="auto">
<div>Hi,<br>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">Stephen Kelly <<a
href="mailto:steveire@gmail.com" moz-do-not-send="true">steveire@gmail.com</a>>
schrieb am So., 29. Dez. 2019, 15:03:<br>
</div>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
On 28/12/2019 23:30, Friedrich W. H. Kossebau wrote:<br>
> Why are you proposing to do a step back instead to
the old state, which<br>
> everyone including you considered not that
satisfying?<br>
<br>
Because it's a temporary situation. We still have a way
forward in KF6 <br>
(which will open in a few months).<br>
<br>
<br>
Generally, getting Grantlee into KF5 now also establishes
the wrong <br>
precedent. Grantlee should be split into two repos each
with a tier 1 <br>
library (KF6::TextDocument and KF6::TextTemplate). The two
are <br>
independent and have nothing to do with each other aside
from <br>
authorship. That seems to be something you were objecting
to, so I want <br>
to make sure that's something addressed on its own. The
two KF6 <br>
libraries will then follow the KF6 naming conventions etc.<br>
</blockquote>
</div>
</div>
<div dir="auto"><br>
</div>
<div dir="auto">With my KTextEditor hat on: KF6:TextDocument
implies somehow a link to QTextDocument or KF6:TextEditor,
which both is incorrect, right?</div>
</div>
</blockquote>
<p><br>
</p>
<p>QTextDocument is exactly what it's about, which makes the name
KF6::TextDocument fully appropriate and correct.<br>
</p>
<p><br>
</p>
<blockquote type="cite"
cite="mid:CALi_srBu+W99wm2ksiZFsiabGJb-S6OKpCbpyNLwDi7p8EacpQ@mail.gmail.com">
<div dir="auto">
<div dir="auto"><br>
</div>
<div dir="auto">Before starting this work, let's clarify whether
we can find a more unique name (like
KF6:GrantleeTextDocument).</div>
<div dir="auto"><br>
</div>
</div>
</blockquote>
<p><br>
</p>
<p>The name I suggest is already correct.<br>
</p>
<p><br>
</p>
<blockquote type="cite"
cite="mid:CALi_srBu+W99wm2ksiZFsiabGJb-S6OKpCbpyNLwDi7p8EacpQ@mail.gmail.com">
<div dir="auto">
<div dir="auto">Since I haven't used Grantlee yet, I sm likely
not the best person to find a better name ;)</div>
</div>
</blockquote>
<p><br>
</p>
<p>Remember, Grantlee is a set of Frameworks (*Just like KF5/6*)
which happens to contain just TWO independent libraries.</p>
<p><br>
</p>
<p>Thanks,</p>
<p><br>
</p>
<p>Stephen.</p>
<p><br>
</p>
<p><br>
</p>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic