[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 108862: QML Plasma Components: improve positioning strategy for inline dialog
From: Sebastian Gottfried <sebastian.gottfried () posteo ! de>
Date: 2017-02-08 12:42:44
Message-ID: 20170208124244.23155.52559 () mimi ! kde ! org
[Download RAW message or body]
--===============5478148449354976678==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/108862/
-----------------------------------------------------------
(Updated Feb. 8, 2017, 12:42 p.m.)
Status
------
This change has been discarded.
Review request for KDE Runtime and Marco Martin.
Repository: kde-runtime
Description
-------
This changes the positioning of the inline dialog in two ways:
1) Offset the dialog vertically so the balloon tip won't poke into the visual parent.
2) Make sure the dialog won't leave the view port in the horizontal dimension. This \
useful for dialogs with parents near the viewport border. The position of the tip is \
adjusted appropriately.
I'm not sure whether this still a bugfix or not and should also go into KDE/4.10. \
Please comment.
Diffs
-----
plasma/declarativeimports/plasmacomponents/qml/private/InlineDialog.qml 2b7b832
Diff: https://git.reviewboard.kde.org/r/108862/diff/
Testing
-------
Tested within KTouch. Works as expected.
File Attachments
----------------
Improved positioning
https://git.reviewboard.kde.org/media/uploaded/files/2013/02/08/improved-inline-dialog-positioning.png
Thanks,
Sebastian Gottfried
--===============5478148449354976678==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/108862/">https://git.reviewboard.kde.org/r/108862/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Runtime and Marco Martin.</div>
<div>By Sebastian Gottfried.</div>
<p style="color: grey;"><i>Updated Feb. 8, 2017, 12:42 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-runtime
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This changes the positioning of the inline dialog in two ways:
1) Offset the dialog vertically so the balloon tip won't poke into the visual \
parent.
2) Make sure the dialog won't leave the view port in the horizontal dimension. \
This useful for dialogs with parents near the viewport border. The position of the \
tip is adjusted appropriately.
I'm not sure whether this still a bugfix or not and should also go into KDE/4.10. \
Please comment.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested within KTouch. Works as expected.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/declarativeimports/plasmacomponents/qml/private/InlineDialog.qml <span \
style="color: grey">(2b7b832)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/108862/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2013/02/08/improved-inline-dialog-positioning.png">Improved \
positioning</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============5478148449354976678==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic