[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 129935: Fix build for GCC 7
From: Christoph Feck <cfeck () kde ! org>
Date: 2017-02-08 11:57:41
Message-ID: 20170208115741.23155.1402 () mimi ! kde ! org
[Download RAW message or body]
--===============2414712698216290859==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129935/#review102448
-----------------------------------------------------------
Ship it!
Ship It!
- Christoph Feck
On Feb. 8, 2017, 10:04 a.m., Antonio Larrosa Jimenez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129935/
> -----------------------------------------------------------
>
> (Updated Feb. 8, 2017, 10:04 a.m.)
>
>
> Review request for kdelibs.
>
>
> Repository: kdelibs
>
>
> Description
> -------
>
> This fixes building with GCC 7 which fails with
> "ISO C++ forbids comparison between pointer and integer [-fpermissive]"
>
>
> Diffs
> -----
>
> kdeui/windowmanagement/netwm.cpp 0c8b0a7d455f40327a03c685b7a7ff2beda901e0
>
> Diff: https://git.reviewboard.kde.org/r/129935/diff/
>
>
> Testing
> -------
>
> I checked that building with GCC 7 shows:
> /usr/src/packages/BUILD/kdelibs-4.14.28/kdeui/windowmanagement/netwm.cpp: In member \
> function 'void NETWinInfo::update(const long unsigned int*)':
> /usr/src/packages/BUILD/kdelibs-4.14.28/kdeui/windowmanagement/netwm.cpp:4371:48: \
> error: ISO C++ forbids comparison between pointer and integer [-fpermissive] \
> p->blockCompositing = (data_ret != None); ^~~~
>
> and the submitted commit fixes this.
>
>
> Thanks,
>
> Antonio Larrosa Jimenez
>
>
--===============2414712698216290859==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129935/">https://git.reviewboard.kde.org/r/129935/</a>
</td>
</tr>
</table>
<br />
<p>
Ship it!
</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<p>- Christoph Feck</p>
<br />
<p>On February 8th, 2017, 10:04 a.m. CET, Antonio Larrosa Jimenez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Antonio Larrosa Jimenez.</div>
<p style="color: grey;"><i>Updated Feb. 8, 2017, 10:04 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This fixes building with GCC 7 which fails with "ISO C++ forbids \
comparison between pointer and integer [-fpermissive]"</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I checked that building with GCC 7 \
shows:
/usr/src/packages/BUILD/kdelibs-4.14.28/kdeui/windowmanagement/netwm.cpp: In member \
function 'void NETWinInfo::update(const long unsigned int*)':
/usr/src/packages/BUILD/kdelibs-4.14.28/kdeui/windowmanagement/netwm.cpp:4371:48: \
error: ISO C++ forbids comparison between pointer and integer [-fpermissive] \
p->blockCompositing = (data_ret != None); ^~~~</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">and the submitted commit fixes this.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdeui/windowmanagement/netwm.cpp <span style="color: \
grey">(0c8b0a7d455f40327a03c685b7a7ff2beda901e0)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129935/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============2414712698216290859==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic