'Review Request 121935: Compile with -Werror=return-true -Wno-variadic-macros'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Review Request 121935: Compile with -Werror=return-true -Wno-variadic-macros
From:       "Jaime Torres Amate" <jtamate () gmail ! com>
Date:       2015-01-08 20:39:04
Message-ID: 20150108203904.28638.21294 () probe ! kde ! org
[Download RAW message or body]

--===============2678019772423665316==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121935/
-----------------------------------------------------------

Review request for kdelibs.


Repository: kactivities


Description
-------

I've been unable to compile frameworks since I added the folowing options to \
kdesrc-buildrc

-Wall -Wformat -Werror=format-security -Werror=return-type -Wno-variadic-macros \
-Wlogical-op


Diffs
-----

  src/imports/resourcemodel.cpp ffdf571 
  src/service/plugins/sqlite/ResourceLinking.cpp be55ff5 
  src/workspace/settings/MainConfigurationWidget.cpp e130d1d 

Diff: https://git.reviewboard.kde.org/r/121935/diff/


Testing
-------

It compiles with gcc 4.9 and clang++ (without those flags)


Thanks,

Jaime Torres Amate


--===============2678019772423665316==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/121935/">https://git.reviewboard.kde.org/r/121935/</a>
  </td>
    </tr>
   </table>
   <br />





<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for kdelibs.</div>
<div>By Jaime Torres Amate.</div>










<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kactivities
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I've been unable to compile frameworks since I added \
the folowing options to kdesrc-buildrc</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">-Wall -Wformat \
-Werror=format-security -Werror=return-type -Wno-variadic-macros \
-Wlogical-op</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">It compiles with gcc 4.9 and clang++ (without those \
flags)</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/imports/resourcemodel.cpp <span style="color: grey">(ffdf571)</span></li>

 <li>src/service/plugins/sqlite/ResourceLinking.cpp <span style="color: \
grey">(be55ff5)</span></li>

 <li>src/workspace/settings/MainConfigurationWidget.cpp <span style="color: \
grey">(e130d1d)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/121935/diff/" style="margin-left: \
3em;">View Diff</a></p>






  </td>
 </tr>
</table>




  </div>
 </body>
</html>


--===============2678019772423665316==--


[prev in list] [next in list] [prev in thread] [next in thread]
Configure | About | News | Add a list | Sponsored by KoreLogic