[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 121930: [OS X] improvements to KSharedData
From: René J.V. Bertin <rjvbertin () gmail ! com>
Date: 2015-01-08 18:19:55
Message-ID: 20150108181955.15695.18419 () probe ! kde ! org
[Download RAW message or body]
--===============3879668581342671497==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On Jan. 8, 2015, 7:12 p.m., Milian Wolff wrote:
> > personally, I also think that if you tested and it works, and Allan has no \
> > objections, that you can go ahead and push this. but please don't comment out \
> > code, just remove it.
OK, will do.
I'll give it a bit more testing, though. Mutex locking without timeouts could lead to \
deadlocks, and maybe that's why the feature was disabled on OS X (maybe someone even \
ran into such a deadlock).
- René J.V.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121930/#review73521
-----------------------------------------------------------
On Jan. 8, 2015, 6:09 p.m., René J.V. Bertin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121930/
> -----------------------------------------------------------
>
> (Updated Jan. 8, 2015, 6:09 p.m.)
>
>
> Review request for KDE Software on Mac OS X, kdelibs and Allen Winter.
>
>
> Repository: kdelibs
>
>
> Description
> -------
>
> This patch improves KSharedData on 2 points:
>
> - It enables `KSDC_THREAD_PROCESS_SHARED_SUPPORTED` on OS X because even if the OS \
> cannot do timeouts on mutex locking, it does have Posix mutexes (pthreads). I don't \
> know why this was deactivated explicitly on OS X (do you remember, Allan?), but \
> haven't seen issues with KSDC_THREAD_PROCESS_SHARED_SUPPORTED - for now.
> - OS X doesn't have `posix_fallocate()`, but an emulation of this function is \
> available in the Mozilla code (reference found on StackOverflow). The code seems to \
> be license-compatible, so I removed the code for non-OS X platforms, and include it \
> in `kshareddatacache_p.h`. Again, this seems to work.
>
> Diffs
> -----
>
> kdecore/util/kshareddatacache_p.h 931de4d
> kdecore/util/posix_fallocate_mac.h PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/121930/diff/
>
>
> Testing
> -------
>
> On OS X 10.9.5 with kdelibs 4.14.4 and KDE PIM 4.13.3 (I use KMail as my default \
> MUA).
>
> Thanks,
>
> René J.V. Bertin
>
>
--===============3879668581342671497==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121930/">https://git.reviewboard.kde.org/r/121930/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On January 8th, 2015, 7:12 p.m. CET, <b>Milian \
Wolff</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">personally, I also think that if you tested and it \
works, and Allan has no objections, that you can go ahead and push this. but please \
don't comment out code, just remove it.</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">OK, \
will do.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I'll give it a bit more testing, though. Mutex locking \
without timeouts could lead to deadlocks, and maybe that's why the feature was \
disabled on OS X (maybe someone even ran into such a deadlock).</p></pre> <br />
<p>- René J.V.</p>
<br />
<p>On January 8th, 2015, 6:09 p.m. CET, René J.V. Bertin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Software on Mac OS X, kdelibs and Allen Winter.</div>
<div>By René J.V. Bertin.</div>
<p style="color: grey;"><i>Updated Jan. 8, 2015, 6:09 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This patch improves KSharedData on 2 points:</p> <ul \
style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: \
inherit;white-space: normal;"> <li style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;"> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">It enables <code \
style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: \
0;line-height: inherit;">KSDC_THREAD_PROCESS_SHARED_SUPPORTED</code> on OS X because \
even if the OS cannot do timeouts on mutex locking, it does have Posix mutexes \
(pthreads). I don't know why this was deactivated explicitly on OS X (do you \
remember, Allan?), but haven't seen issues with KSDC_THREAD_PROCESS_SHARED_SUPPORTED \
- for now.</p> </li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;"> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">OS X doesn't have <code \
style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: \
0;line-height: inherit;">posix_fallocate()</code>, but an emulation of this function \
is available in the Mozilla code (reference found on StackOverflow). The code seems \
to be license-compatible, so I removed the code for non-OS X platforms, and include \
it in <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: \
normal;margin: 0;line-height: inherit;">kshareddatacache_p.h</code>. Again, this \
seems to work.</p> </li>
</ul></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">On OS X 10.9.5 with kdelibs 4.14.4 and KDE PIM 4.13.3 \
(I use KMail as my default MUA).</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdecore/util/kshareddatacache_p.h <span style="color: \
grey">(931de4d)</span></li>
<li>kdecore/util/posix_fallocate_mac.h <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121930/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============3879668581342671497==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic