[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 120630: Port from KTempDir to QTemporaryDir. Port from KUrl to QUrl.
From: "Kevin Kofler" <kevin.kofler () chello ! at>
Date: 2014-10-17 22:46:48
Message-ID: 20141017224648.21224.27140 () probe ! kde ! org
[Download RAW message or body]
--===============6670294564370288421==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120630/#review68635
-----------------------------------------------------------
Ship it!
I'm approving this one, but please only push it when the Kompare patch is also ready \
to be pushed.
- Kevin Kofler
On Okt. 17, 2014, 4:21 nachm., Jeremy Whiting wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120630/
> -----------------------------------------------------------
>
> (Updated Okt. 17, 2014, 4:21 nachm.)
>
>
> Review request for kdelibs and Kevin Kofler.
>
>
> Repository: libkomparediff2
>
>
> Description
> -------
>
> Port from KTempDir to QTemporaryDir.
>
>
> Diffs
> -----
>
> kompare.h a8f3c5a71995c8416f9089f3c263f3691c9bfab5
> kompare.cpp e44b8a3dcf59a43de426b28c39412d4331949412
>
> Diff: https://git.reviewboard.kde.org/r/120630/diff/
>
>
> Testing
> -------
>
> It builds and an updated kompare frameworks branch builds against it and runs.
>
>
> Thanks,
>
> Jeremy Whiting
>
>
--===============6670294564370288421==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120630/">https://git.reviewboard.kde.org/r/120630/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'm \
approving this one, but please only push it when the Kompare patch is also ready to \
be pushed.</p></pre> <br />
<p>- Kevin Kofler</p>
<br />
<p>On Oktober 17th, 2014, 4:21 nachm. UTC, Jeremy Whiting wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for kdelibs and Kevin Kofler.</div>
<div>By Jeremy Whiting.</div>
<p style="color: grey;"><i>Updated Okt. 17, 2014, 4:21 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
libkomparediff2
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Port from KTempDir to QTemporaryDir.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">It builds and an updated kompare frameworks branch \
builds against it and runs.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kompare.h <span style="color: \
grey">(a8f3c5a71995c8416f9089f3c263f3691c9bfab5)</span></li>
<li>kompare.cpp <span style="color: \
grey">(e44b8a3dcf59a43de426b28c39412d4331949412)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120630/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============6670294564370288421==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic