--===============6670294564370288421== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120630/#review68635 ----------------------------------------------------------- Ship it! I'm approving this one, but please only push it when the Kompare patch is also ready to be pushed. - Kevin Kofler On Okt. 17, 2014, 4:21 nachm., Jeremy Whiting wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120630/ > ----------------------------------------------------------- > > (Updated Okt. 17, 2014, 4:21 nachm.) > > > Review request for kdelibs and Kevin Kofler. > > > Repository: libkomparediff2 > > > Description > ------- > > Port from KTempDir to QTemporaryDir. > > > Diffs > ----- > > kompare.h a8f3c5a71995c8416f9089f3c263f3691c9bfab5 > kompare.cpp e44b8a3dcf59a43de426b28c39412d4331949412 > > Diff: https://git.reviewboard.kde.org/r/120630/diff/ > > > Testing > ------- > > It builds and an updated kompare frameworks branch builds against it and runs. > > > Thanks, > > Jeremy Whiting > > --===============6670294564370288421== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120630/

Ship it!

I'm approving this one, but please only push it when the Kompare patch is also ready to be pushed.

- Kevin Kofler


On Oktober 17th, 2014, 4:21 nachm. UTC, Jeremy Whiting wrote:

Review request for kdelibs and Kevin Kofler.
By Jeremy Whiting.

Updated Okt. 17, 2014, 4:21 nachm.

Repository: libkomparediff2

Description 

Port from KTempDir to QTemporaryDir.

Testing 

It builds and an updated kompare frameworks branch builds against it and runs.

Diffs

  • kompare.h (a8f3c5a71995c8416f9089f3c263f3691c9bfab5)
  • kompare.cpp (e44b8a3dcf59a43de426b28c39412d4331949412)

View Diff
--===============6670294564370288421==--