[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 120287: [OS X] make kde-workspace build
From: René J.V. Bertin <rjvbertin () gmail ! com>
Date: 2014-09-22 16:17:32
Message-ID: 20140922161732.6971.9529 () probe ! kde ! org
[Download RAW message or body]
--===============8039550176739439622==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120287/
-----------------------------------------------------------
(Updated Sept. 22, 2014, 6:17 p.m.)
Review request for KDE Software on Mac OS X and kde-workspace.
Changes
-------
Dropped kcheckpass (could be made to work but seems to be of little use) and \
qguiplatformplugin_kde, as suggested.
Note that someone looking for a nice programming exercise *could* port `ksysguard` to \
OS X! Is that component used for anything that could be of actual use on OS X?
Repository: kde-workspace
Description
-------
A few rather straightforward patches to make the relevant bits of KDE4's \
kde-workspace build and function on OS X. The main interest is having the \
systemsettings control panel to control the various relevant KDE settings among which \
desktop search, fonts, colours and even style. The oxygen style builds and looks good \
but shows some updating glitches due to compositing.
I'm submitting this patch partly in hope it may be useful in bringing kf5-workspace \
to OS X, one day.
Diffs (updated)
-----
kcontrol/krdb/krdb.cpp 36fc99c
kcontrol/style/CMakeLists.txt d832b20
libs/CMakeLists.txt c0576fe
qguiplatformplugin_kde/qguiplatformplugin_kde.cpp 4f67cc5
CMakeLists.txt 195f99c
kcontrol/CMakeLists.txt fc666b1
Diff: https://git.reviewboard.kde.org/r/120287/diff/
Testing
-------
On OS X 10.6.8 and 10.9.4 with KDE/MacPorts (4.12.5 and more recently kdelibs \
git/master, 4.14.1).
File Attachments
----------------
copy of the diff file saved locally, which had no tabs when I uploaded it. Checksum: \
3989cdd46af3c891e570974d66c330403dcd41c4ee5e17a372fa385080cbabd1 \
https://git.reviewboard.kde.org/media/uploaded/files/2014/09/20/b212730f-6258-4277-851c-226bc0673aa1__patchreview-20140920.patch
Thanks,
René J.V. Bertin
--===============8039550176739439622==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120287/">https://git.reviewboard.kde.org/r/120287/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Software on Mac OS X and kde-workspace.</div>
<div>By René J.V. Bertin.</div>
<p style="color: grey;"><i>Updated Sept. 22, 2014, 6:17 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Dropped kcheckpass (could be made to work but seems to be of little use) \
and qguiplatformplugin_kde, as suggested.
Note that someone looking for a nice programming exercise *could* port `ksysguard` to \
OS X! Is that component used for anything that could be of actual use on OS X?</pre> \
</td> </tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">A few rather straightforward patches to make the \
relevant bits of KDE4's kde-workspace build and function on OS X.<br style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" /> The \
main interest is having the systemsettings control panel to control the various \
relevant KDE settings among which desktop search, fonts, colours and even style.<br \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;" /> The oxygen style builds and looks good but shows some updating glitches \
due to compositing.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">I'm submitting this patch partly in \
hope it may be useful in bringing kf5-workspace to OS X, one day.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">On OS X 10.6.8 and 10.9.4 with KDE/MacPorts (4.12.5 \
and more recently kdelibs git/master, 4.14.1).</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>kcontrol/krdb/krdb.cpp <span style="color: grey">(36fc99c)</span></li>
<li>kcontrol/style/CMakeLists.txt <span style="color: grey">(d832b20)</span></li>
<li>libs/CMakeLists.txt <span style="color: grey">(c0576fe)</span></li>
<li>qguiplatformplugin_kde/qguiplatformplugin_kde.cpp <span style="color: \
grey">(4f67cc5)</span></li>
<li>CMakeLists.txt <span style="color: grey">(195f99c)</span></li>
<li>kcontrol/CMakeLists.txt <span style="color: grey">(fc666b1)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120287/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/09/20/b212730f-6258-4277-851c-226bc0673aa1__patchreview-20140920.patch">copy \
of the diff file saved locally, which had no tabs when I uploaded it. Checksum: \
3989cdd46af3c891e570974d66c330403dcd41c4ee5e17a372fa385080cbabd1 </a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============8039550176739439622==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic