[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 120287: [OS X] make kde-workspace build
From: René J.V. Bertin <rjvbertin () gmail ! com>
Date: 2014-09-22 13:14:36
Message-ID: 20140922131436.6971.71397 () probe ! kde ! org
[Download RAW message or body]
--===============1195262288656423691==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On Sept. 20, 2014, 3:51 p.m., Martin Gräßlin wrote:
> > CMakeLists.txt, lines 223-239
> > <https://git.reviewboard.kde.org/r/120287/diff/5/?file=313819#file313819line223>
> >
> > out of interest: this is now a huge NOT WIN32 block with two NOT APPLE blocks. If \
> > I see correctly, what remains being built on Apple is:
> > * kcheckpass
> > * qguiplatformplugin_kde
> >
> > Somehow I doubt kcheckpass will work on MacOS (it uses PAM) or is of any need \
> > (only used by kscreenlocker_greet in ksmserver which is not built). And \
> > qguiplatformplugin_kde should not be of any use on MacOS either because it's the \
> > Qt plugin for a Plasma session and shouldn't (TM) be used on other platforms.
> > So if I see correctly you could just merge the whole thing into a
> > if(NOT WIN32 AND NOT APPLE)
>
> René J.V. Bertin wrote:
> Are you very sure about that? I see things related to KFileDialog and KColorDialog, \
> and I don't see why those would only be relevant from inside a Plasma session...
> What would be the best place where I could put some kind of output expression that \
> I ought NOT to see if indeed the platform plugin isn't used?
> I also remember someone (Thomas?) mention it in the context of doing an override of \
> a Qt setting at a very low, early level during application initialisation.
> Thomas Lübking wrote:
> You would want to alter qguiplatformplugin_osx (not sure about the _osx name part) \
> since that is what will be loaded on OSX if you're eg. running kwrite in the \
> default OSX shell. You will (hopefully) get the OSX native filedialogs and color \
> pickers from any Qt application for this, not the foreign KDE ones.
> Martin Gräßlin wrote:
> exactly as Thomas writes: this is the platform plugin for the kde workspaces. On \
> MacOS you don't have the kde workspaces and thus don't want to load it. You want to \
> get the mac os plugin to have integration with mac os.
> René J.V. Bertin wrote:
> Understood, and indeed I haven't been able to find evidence of \
> qguiplatformplugin_kde to be invoked. The name is a bit misleading if it's only \
> used for workspaces. I cannot find a qguiplatformplugin for OS X, though; are you \
> sure there is one in KDE4?
> BTW, the systemsettings control panel does show the Workspace Settings kcm, which \
> has 1 active control: `Show Informational Tips`. Would you know if that control \
> does anything - if it modifies `kdeglobalrc` I presume it at least might?
> Martin Gräßlin wrote:
> > The name is a bit misleading if it's only used for workspaces.
>
> well it's in kde-workspace - that kind of implies it's just for the kde-workspace. \
> Otherwise it would be in kde-runtime or libs.
> > I cannot find a qguiplatformplugin for OS X, though; are you sure there is one in \
> > KDE4?
>
> it should be in Qt.
>
> > BTW, the systemsettings control panel does show the Workspace Settings kcm, which \
> > has 1 active control: Show Informational Tips. Would you know if that control \
> > does anything - if it modifies kdeglobalrc I presume it at least might?
>
> tool tip settings for Plasma. You don't need that.
>
> Thomas Lübking wrote:
> just checked: Qt4 has
> - qcolordialog_mac.mm
> - qfiledialog_mac.mm
> - qfontdialog_mac.mm
> - qnspanelproxy_mac.mm
> - qpagesetupdialog_mac.mm
> - qprintdialog_mac.mm
>
> in src/gui/dialogs - it's not done via a plugin but wrapped directly.
>
> René J.V. Bertin wrote:
> Heh, a good reason why KDevelop should at least handle ObjC++ (.mm) files as if \
> they were regular C++ files ;)
> Should I understand there are 2 tooltip settings? We may not need them in Plasma, \
> but should be able to have them elsewhere.
> Martin Gräßlin wrote:
> > Should I understand there are 2 tooltip settings? We may not need them in Plasma, \
> > but should be able to have them elsewhere.
>
> the setting in the Workspace Settings kcm is just for Plasma. It's not about \
> tooltips in the applications, it's about the tooltips the desktop shell uses.
Not directly related to kde-workspace, but would it be possible to override Qt's \
scrollwheel zoom feature? That's coupled to the Command key on OS X and the event \
appears not to make a distinction between scrolling under direct control and residual \
scroll motion due to inertia. The result is that I often trigger (text) zoom when I \
want to use a shortcut instead but the view I'm in hasn't yet stopped scrolling \
completely.
- René J.V.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120287/#review67071
-----------------------------------------------------------
On Sept. 20, 2014, 2:52 p.m., René J.V. Bertin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120287/
> -----------------------------------------------------------
>
> (Updated Sept. 20, 2014, 2:52 p.m.)
>
>
> Review request for KDE Software on Mac OS X and kde-workspace.
>
>
> Repository: kde-workspace
>
>
> Description
> -------
>
> A few rather straightforward patches to make the relevant bits of KDE4's \
> kde-workspace build and function on OS X. The main interest is having the \
> systemsettings control panel to control the various relevant KDE settings among \
> which desktop search, fonts, colours and even style. The oxygen style builds and \
> looks good but shows some updating glitches due to compositing.
> I'm submitting this patch partly in hope it may be useful in bringing kf5-workspace \
> to OS X, one day.
>
> Diffs
> -----
>
> CMakeLists.txt 195f99c
> kcontrol/CMakeLists.txt fc666b1
> kcontrol/krdb/krdb.cpp 36fc99c
> kcontrol/style/CMakeLists.txt d832b20
> libs/CMakeLists.txt c0576fe
>
> Diff: https://git.reviewboard.kde.org/r/120287/diff/
>
>
> Testing
> -------
>
> On OS X 10.6.8 and 10.9.4 with KDE/MacPorts (4.12.5 and more recently kdelibs \
> git/master, 4.14.1).
>
> File Attachments
> ----------------
>
> copy of the diff file saved locally, which had no tabs when I uploaded it. \
> Checksum: 3989cdd46af3c891e570974d66c330403dcd41c4ee5e17a372fa385080cbabd1 \
> https://git.reviewboard.kde.org/media/uploaded/files/2014/09/20/b212730f-6258-4277-851c-226bc0673aa1__patchreview-20140920.patch
>
>
> Thanks,
>
> René J.V. Bertin
>
>
--===============1195262288656423691==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120287/">https://git.reviewboard.kde.org/r/120287/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On September 20th, 2014, 3:51 p.m. CEST, <b>Martin \
Gräßlin</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/120287/diff/5/?file=313819#file313819line223" \
style="color: black; font-weight: bold; text-decoration: \
underline;">CMakeLists.txt</a> <span style="font-weight: normal;">
(Diff revision 5)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">223</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="nb">if</span><span class="p">(</span><span class="s">NOT</span> <span \
class="s">WIN32</span><span class="p">)</span></pre></td> <th bgcolor="#f0f0f0" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">223</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="nb">if</span><span class="p">(</span><span class="s">NOT</span> <span \
class="s">WIN32</span><span class="p">)</span></pre></td> </tr>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">224</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="nb">macro_optional_add_subdirectory</span><span class="p">(</span> <span \
class="s">kcheckpass</span> <span class="p">)</span></pre></td> <th \
bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">224</font></th> <td bgcolor="#ffffff" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="nb">macro_optional_add_subdirectory</span><span class="p">(</span> <span \
class="s">kcheckpass</span> <span class="p">)</span></pre></td> </tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">225</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="nb">if</span><span class="p">(</span><span class="s">NOT</span> <span \
class="s">APPLE</span><span class="p">)</span></pre></td> </tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">225</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="nb">macro_optional_add_subdirectory</span><span class="p">(</span> <span \
class="s">kwin</span> <span class="p">)</span></pre></td> <th bgcolor="#f0f0f0" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">226</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="indent">>>></span> <span \
class="nb">macro_optional_add_subdirectory</span><span class="p">(</span> <span \
class="s">kwin</span> <span class="p">)</span></pre></td> </tr>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">226</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="nb">macro_optional_add_subdirectory</span><span class="p">(</span> <span \
class="s">ksmserver</span> <span class="p">)</span></pre></td> <th bgcolor="#f0f0f0" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">227</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="indent">>>></span> <span \
class="nb">macro_optional_add_subdirectory</span><span class="p">(</span> <span \
class="s">ksmserver</span> <span class="p">)</span></pre></td> </tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">227</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">228</font></th> <td bgcolor="#ffffff" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> \
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">228</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="nb">find_package</span><span class="p">(</span><span class="s">JPEG</span> \
<span class="s">REQUIRED</span><span class="p">)</span></pre></td> <th \
bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">229</font></th> <td bgcolor="#ffffff" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="indent">>>></span> <span class="nb">find_package</span><span \
class="p">(</span><span class="s">JPEG</span> <span class="s">REQUIRED</span><span \
class="p">)</span></pre></td> </tr>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">229</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="nb">find_package</span><span class="p">(</span><span class="s">PNG</span> \
<span class="s">REQUIRED</span><span class="p">)</span></pre></td> <th \
bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">230</font></th> <td bgcolor="#ffffff" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="indent">>>></span> <span class="nb">find_package</span><span \
class="p">(</span><span class="s">PNG</span> <span class="s">REQUIRED</span><span \
class="p">)</span></pre></td> </tr>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">230</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="nb">macro_optional_add_subdirectory</span><span class="p">(</span> <span \
class="s">ksplash</span> <span class="p">)</span></pre></td> <th bgcolor="#f0f0f0" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">231</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="indent">>>></span> <span \
class="nb">macro_optional_add_subdirectory</span><span class="p">(</span> <span \
class="s">ksplash</span> <span class="p">)</span></pre></td> </tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">231</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">232</font></th> <td bgcolor="#ffffff" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> \
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">232</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="nb">macro_optional_add_subdirectory</span><span class="p">(</span> <span \
class="s">powerdevil</span> <span class="p">)</span></pre></td> <th \
bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">233</font></th> <td bgcolor="#ffffff" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="indent">>>></span> <span \
class="nb">macro_optional_add_subdirectory</span><span class="p">(</span> <span \
class="s">powerdevil</span> <span class="p">)</span></pre></td> </tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">234</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="nb">endif</span><span class="p">(</span><span class="s">NOT</span> <span \
class="s">APPLE</span><span class="p">)</span></pre></td> </tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">233</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="nb">macro_optional_add_subdirectory</span><span class="p">(</span> <span \
class="s">qguiplatformplugin_kde</span> <span class="p">)</span></pre></td> <th \
bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">235</font></th> <td bgcolor="#ffffff" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="nb">macro_optional_add_subdirectory</span><span class="p">(</span> <span \
class="s">qguiplatformplugin_kde</span> <span class="p">)</span></pre></td> </tr>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">234</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="nb">if</span> \
<span class="p">(</span><span class="s">NOT</span> <span \
class="s">CMAKE_SYSTEM_NAME</span> <span class="s">MATCHES</span> <span \
class="s">Darwin</span><span class="p">)</span></pre></td> <th bgcolor="#f0f0f0" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">236</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="nb">if</span> \
<span class="p">(</span><span class="s">NOT</span> <span \
class="s">CMAKE_SYSTEM_NAME</span> <span class="s">MATCHES</span> <span \
class="s">Darwin</span><span class="p">)</span></pre></td> </tr>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">235</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="nb">macro_optional_add_subdirectory</span><span class="p">(</span> <span \
class="s">ksysguard</span> <span class="p">)</span></pre></td> <th bgcolor="#f0f0f0" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">237</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="nb">macro_optional_add_subdirectory</span><span class="p">(</span> <span \
class="s">ksysguard</span> <span class="p">)</span></pre></td> </tr>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">236</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="nb">endif</span> <span class="p">(</span><span class="s">NOT</span> <span \
class="s">CMAKE_SYSTEM_NAME</span> <span class="s">MATCHES</span> <span \
class="s">Darwin</span><span class="p">)</span></pre></td> <th bgcolor="#f0f0f0" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">238</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="nb">endif</span> <span class="p">(</span><span class="s">NOT</span> <span \
class="s">CMAKE_SYSTEM_NAME</span> <span class="s">MATCHES</span> <span \
class="s">Darwin</span><span class="p">)</span></pre></td> </tr>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">237</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="nb">endif</span><span class="p">(</span><span class="s">NOT</span> <span \
class="s">WIN32</span><span class="p">)</span></pre></td> <th bgcolor="#f0f0f0" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">239</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="nb">endif</span><span class="p">(</span><span class="s">NOT</span> <span \
class="s">WIN32</span><span class="p">)</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">out \
of interest: this is now a huge NOT WIN32 block with two NOT APPLE blocks. If I see \
correctly, what remains being built on Apple is:<br style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;" /> <em style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;"> \
kcheckpass<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;" /> </em> qguiplatformplugin_kde</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Somehow I doubt kcheckpass will work on MacOS (it uses \
PAM) or is of any need (only used by kscreenlocker_greet in ksmserver which is not \
built). And qguiplatformplugin_kde should not be of any use on MacOS either because \
it's the Qt plugin for a Plasma session and shouldn't (TM) be used on other \
platforms.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">So if I see correctly you could just merge the whole \
thing into a<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;" /> if(NOT WIN32 AND NOT APPLE)</p></pre>
</blockquote>
<p>On September 21st, 2014, 12:19 p.m. CEST, <b>René J.V. Bertin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Are \
you very sure about that? I see things related to KFileDialog and KColorDialog, and I \
don't see why those would only be relevant from inside a Plasma session...</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">What would be the best place where I could put some kind of output \
expression that I ought NOT to see if indeed the platform plugin isn't used?</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">I also remember someone (Thomas?) mention it in the context of doing an \
override of a Qt setting at a very low, early level during application \
initialisation.</p></pre> </blockquote>
<p>On September 21st, 2014, 1:28 p.m. CEST, <b>Thomas Lübking</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">You \
would want to alter qguiplatformplugin_osx (not sure about the _osx name part) since \
that is what will be loaded on OSX if you're eg. running kwrite in the default OSX \
shell.<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;" /> You will (hopefully) get the OSX native filedialogs \
and color pickers from any Qt application for this, not the foreign KDE \
ones.</p></pre> </blockquote>
<p>On September 22nd, 2014, 8:34 a.m. CEST, <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">exactly as Thomas writes: this is the platform plugin for the kde \
workspaces. On MacOS you don't have the kde workspaces and thus don't want to load \
it. You want to get the mac os plugin to have integration with mac os.</p></pre> \
</blockquote>
<p>On September 22nd, 2014, 12:24 p.m. CEST, <b>René J.V. Bertin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Understood, and indeed I haven't been able to find evidence of \
qguiplatformplugin_kde to be invoked. The name is a bit misleading if it's only used \
for workspaces. I cannot find a qguiplatformplugin for OS X, though; are you sure \
there is one in KDE4?</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">BTW, the systemsettings control panel \
does show the Workspace Settings kcm, which has 1 active control: <code \
style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: \
0;line-height: inherit;">Show Informational Tips</code>. Would you know if that \
control does anything - if it modifies <code style="text-rendering: inherit;color: \
#4444cc;padding: 0;white-space: normal;margin: 0;line-height: \
inherit;">kdeglobalrc</code> I presume it at least might?</p></pre> </blockquote>
<p>On September 22nd, 2014, 12:29 p.m. CEST, <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><blockquote \
style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid \
#bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;"> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">The name is a bit misleading if it's only used for workspaces.</p> \
</blockquote> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">well it's in kde-workspace - that kind of implies it's \
just for the kde-workspace. Otherwise it would be in kde-runtime or libs.</p> \
<blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid \
#bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;"> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">I cannot find a qguiplatformplugin for OS X, though; are you sure there is \
one in KDE4?</p> </blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">it should be in Qt.</p> <blockquote \
style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid \
#bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;"> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">BTW, the systemsettings control panel does show the Workspace Settings kcm, \
which has 1 active control: Show Informational Tips. Would you know if that control \
does anything - if it modifies kdeglobalrc I presume it at least might?</p> \
</blockquote> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">tool tip settings for Plasma. You don't need \
that.</p></pre> </blockquote>
<p>On September 22nd, 2014, 1:02 p.m. CEST, <b>Thomas Lübking</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">just \
checked: Qt4 has<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;" />
- qcolordialog_mac.mm<br style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;" />
- qfiledialog_mac.mm<br style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;" />
- qfontdialog_mac.mm<br style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;" />
- qnspanelproxy_mac.mm<br style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;" />
- qpagesetupdialog_mac.mm<br style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;" />
- qprintdialog_mac.mm </p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">in src/gui/dialogs - it's not done via a plugin but \
wrapped directly.</p></pre> </blockquote>
<p>On September 22nd, 2014, 1:29 p.m. CEST, <b>René J.V. Bertin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Heh, \
a good reason why KDevelop should at least handle ObjC++ (.mm) files as if they were \
regular C++ files ;)</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Should I understand there are 2 tooltip \
settings? We may not need them in Plasma, but should be able to have them \
elsewhere.</p></pre> </blockquote>
<p>On September 22nd, 2014, 1:49 p.m. CEST, <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><blockquote \
style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid \
#bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;"> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Should I understand there are 2 tooltip settings? We may not need them in \
Plasma, but should be able to have them elsewhere.</p> </blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">the setting in the Workspace Settings kcm is just for \
Plasma. It's not about tooltips in the applications, it's about the tooltips the \
desktop shell uses.</p></pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Not directly related to kde-workspace, but would it be possible to override \
Qt's scrollwheel zoom feature? That's coupled to the Command key on OS X and the \
event appears not to make a distinction between scrolling under direct control and \
residual scroll motion due to inertia. The result is that I often trigger (text) zoom \
when I want to use a shortcut instead but the view I'm in hasn't yet stopped \
scrolling completely.</p></pre> <br />
<p>- René J.V.</p>
<br />
<p>On September 20th, 2014, 2:52 p.m. CEST, René J.V. Bertin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Software on Mac OS X and kde-workspace.</div>
<div>By René J.V. Bertin.</div>
<p style="color: grey;"><i>Updated Sept. 20, 2014, 2:52 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">A few rather straightforward patches to make the \
relevant bits of KDE4's kde-workspace build and function on OS X.<br style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" /> The \
main interest is having the systemsettings control panel to control the various \
relevant KDE settings among which desktop search, fonts, colours and even style.<br \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;" /> The oxygen style builds and looks good but shows some updating glitches \
due to compositing.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">I'm submitting this patch partly in \
hope it may be useful in bringing kf5-workspace to OS X, one day.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">On OS X 10.6.8 and 10.9.4 with KDE/MacPorts (4.12.5 \
and more recently kdelibs git/master, 4.14.1).</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(195f99c)</span></li>
<li>kcontrol/CMakeLists.txt <span style="color: grey">(fc666b1)</span></li>
<li>kcontrol/krdb/krdb.cpp <span style="color: grey">(36fc99c)</span></li>
<li>kcontrol/style/CMakeLists.txt <span style="color: grey">(d832b20)</span></li>
<li>libs/CMakeLists.txt <span style="color: grey">(c0576fe)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120287/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/09/20/b212730f-6258-4277-851c-226bc0673aa1__patchreview-20140920.patch">copy \
of the diff file saved locally, which had no tabs when I uploaded it. Checksum: \
3989cdd46af3c891e570974d66c330403dcd41c4ee5e17a372fa385080cbabd1 </a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============1195262288656423691==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic