[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 120202: [OS X] improvements to the kwallet/OSX keychain integration
From: René J.V. Bertin <rjvbertin () gmail ! com>
Date: 2014-09-21 19:44:16
Message-ID: 20140921194416.6970.89827 () probe ! kde ! org
[Download RAW message or body]
--===============2051624370754647280==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On Sept. 21, 2014, 8:11 p.m., Thomas Lübking wrote:
> > kdeui/util/qosxkeychain.h, line 99
> > <https://git.reviewboard.kde.org/r/120202/diff/2/?file=314175#file314175line99>
> >
> > If OSXKaychain is an exported class (i don't know), this is an ABI incompatible \
> > change.
> > It's also massively invasive and adds quite some overhead.
> >
> > Why did you not just remove the #ifdef from the slot declaration in Wallet \
> > (former patch) and #ifdef the implementation body instead? (There are several \
> > such internal slots present, you don't have to "fix" the Wallet architecture with \
> > this patch ;-)
> >
> > If there's absolutely no other solution and you do not want to add the slot \
> > unconditionally, you can still reimplement protected ::timerEvent() and do the \
> > timer "the hard way", ie. "myTimer = startTimer(timeout); ... if (te->timerId() \
> > == myTimer()) { blahFoo; } else BaseClass::timerEvent(te);"
I would never have done things this way if QOSXKeychain was an exported class... but \
I'm sensible to the overhead argument. I also realise I could probably have declared \
it `protected QObject`. I considered your suggestion, but decided against it because \
it would require patching kwallet.cpp too. Or at least I think it would, I presume \
one has to provide an implementation for every member function that's declared in the \
header? Unless one can make the declaration virtual and only provide an \
implementation in kwallet_mac.cpp (the sort of detail I just cannot seem to memorise \
:-/ )?
- René J.V.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120202/#review67155
-----------------------------------------------------------
On Sept. 21, 2014, 6:40 p.m., René J.V. Bertin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120202/
> -----------------------------------------------------------
>
> (Updated Sept. 21, 2014, 6:40 p.m.)
>
>
> Review request for KDE Software on Mac OS X and kdelibs.
>
>
> Repository: kdelibs
>
>
> Description
> -------
>
> I'm still working on (the KDE4-based version of) my OS X keychain backend for \
> kwallet. I'm at a point where I think I can present a work-in-progress in an RR \
> because at least one feature has been improved enough to be of interest for \
> everyone, and also because I could use feedback on how to proceed. I'm currently \
> focussing on 2 settings that are configured in the kwallet KCM (SystemSettings), \
> and for which I'm working on an implementation not requiring kwalletd and/or DBus.
> - idle time closing of wallets. This feature was not supported in the commited \
> version presented in https://git.reviewboard.kde.org/r/119838/ The present patch \
> adds an idleTimer and a shared lastAccessTime member. The idleTimer is reset each \
> time a client performs one of a series of actions that I count as wallet accesses, \
> and before resetting I update the idle timeout value from KConfig. When the timer \
> fires, the elapsed time is compared to the shared last access time, and if it is >= \
> the timeout, the wallet is closed. This applies only to "KDE keychains", so \
> keychains used by OS X applications should not be affected.
> - "close when last application exits". This requires maintaining a "user list" \
> which keeps track of what application has what wallet open. I've implemented an \
> "internal" version of such a registry, mapping wallet name to application names and \
> the list of wallets they have open (a list of wallet reference, pid per application \
> name). The registry is functional, but I have not yet decided (read: figured out) \
> how to make a distributed representation of it.
> So the work-in-progress concerns the distributed user registry. The idea would be \
> to maintain the registry in shared memory, meaning it'd be reset (= disappear) when \
> the last application exits, contrary to a file which can go stale. This would be \
> simple if QSharedMemory objects could be resized, but apparently they cannot, so \
> I'll have to look at other solutions possibly involving OS X frameworks (NSData and \
> it's non-objectiveC version CFDataRef or CFMutableDataRef might be candidates). \
> Suggestions welcome.
> Other work in progress concerns a less wheel-reinventing approach that builds on \
> kwalletd and DBus. I don't see why the code used in `kwallet.cpp` wouldn't work, \
> but I must still misunderstand its finer details. The present patch contains \
> outcommented code that does indeed cause kwalletd to be launched and slots and \
> signals to become visible e.g. in `qdbusviewer`. But they don't work, which in turn \
> makes the whole kwallet layer dysfunctional. Here too feedback is welcome on how \
> what I'm missing and/or how to get this to work. Once kwalletd works, wallet idle \
> timeout closing and closing when the last client exits should work out-of-the-box, \
> or at least I suppose.
>
> Diffs
> -----
>
> kdeui/util/kwallet.h d7f703f
> kdeui/util/kwallet_mac.cpp 8344ebb
> kdeui/util/qosxkeychain.h d0934e6
> kdeui/util/qosxkeychain.cpp 7cb9a22
>
> Diff: https://git.reviewboard.kde.org/r/120202/diff/
>
>
> Testing
> -------
>
> OS X 10.6.8, kdelibs 4.14.1 git/master, KDE/MacPorts 4.12.5 .
> Once finalised, all changes should port easily to KF5's kwallet_mac.cpp .
>
>
> Thanks,
>
> René J.V. Bertin
>
>
--===============2051624370754647280==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120202/">https://git.reviewboard.kde.org/r/120202/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On September 21st, 2014, 8:11 p.m. CEST, <b>Thomas \
Lübking</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/120202/diff/2/?file=314175#file314175line99" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kdeui/util/qosxkeychain.h</a> <span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">class \
OSXKeychain</pre></td> <td colspan="2"><pre style="font-size: 8pt; line-height: \
140%; margin: 0; ">class OSXKeychain : public QObject</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">90</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="n">class</span> \
<span class="n">OSXKeychain</span></pre></td> <th bgcolor="#e9eaa8" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">98</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="n">class</span> \
<span class="n">OSXKeychain</span><span class="hl"> </span><span class="o"><span \
class="hl">:</span></span><span class="hl"> </span><span class="n"><span \
class="hl">public</span></span><span class="hl"> </span><span class="n"><span \
class="hl">QObject</span></span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">If \
OSXKaychain is an exported class (i don't know), this is an ABI incompatible \
change.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">It's also massively invasive and adds quite some \
overhead.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Why did you not just remove the #ifdef from the slot \
declaration in Wallet (former patch) and #ifdef the implementation body instead?<br \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;" /> (There are several such internal slots present, you don't have to "fix" \
the Wallet architecture with this patch ;-)</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">If there's absolutely \
no other solution and you do not want to add the slot unconditionally, you can still \
reimplement protected ::timerEvent() and do the timer "the hard way", ie. "myTimer = \
startTimer(timeout); ... if (te->timerId() == myTimer()) { blahFoo; } else \
BaseClass::timerEvent(te);"</p></pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">I would never have done things this way if QOSXKeychain was an exported \
class... but I'm sensible to the overhead argument. I also realise I could probably \
have declared it <code style="text-rendering: inherit;color: #4444cc;padding: \
0;white-space: normal;margin: 0;line-height: inherit;">protected QObject</code>.<br \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;" /> I considered your suggestion, but decided against it because it would \
require patching kwallet.cpp too. Or at least I think it would, I presume one has to \
provide an implementation for every member function that's declared in the header? \
Unless one can make the declaration virtual and only provide an implementation in \
kwallet_mac.cpp (the sort of detail I just cannot seem to memorise :-/ )?</p></pre> \
<br />
<p>- René J.V.</p>
<br />
<p>On September 21st, 2014, 6:40 p.m. CEST, René J.V. Bertin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Software on Mac OS X and kdelibs.</div>
<div>By René J.V. Bertin.</div>
<p style="color: grey;"><i>Updated Sept. 21, 2014, 6:40 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I'm still working on (the KDE4-based version of) my OS \
X keychain backend for kwallet. I'm at a point where I think I can present a \
work-in-progress in an RR because at least one feature has been improved enough to be \
of interest for everyone, and also because I could use feedback on how to proceed.<br \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;" /> I'm currently focussing on 2 settings that are configured in the kwallet \
KCM (SystemSettings), and for which I'm working on an implementation not requiring \
kwalletd and/or DBus.</p> <ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 \
1em;line-height: inherit;white-space: normal;"> <li style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;"> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">idle \
time closing of wallets. This feature was not supported in the commited version \
presented in https://git.reviewboard.kde.org/r/119838/ The present patch adds an \
idleTimer and a shared lastAccessTime member. The idleTimer is reset each time a \
client performs one of a series of actions that I count as wallet accesses, and \
before resetting I update the idle timeout value from KConfig. When the timer fires, \
the elapsed time is compared to the shared last access time, and if it is >= the \
timeout, the wallet is closed. This applies only to "KDE keychains", so keychains \
used by OS X applications should not be affected.</p> </li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;"> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">"close when last application exits". \
This requires maintaining a "user list" which keeps track of what application has \
what wallet open. I've implemented an "internal" version of such a registry, mapping \
wallet name to application names and the list of wallets they have open (a list of \
wallet reference, pid per application name). The registry is functional, but I have \
not yet decided (read: figured out) how to make a distributed representation of \
it.</p> </li>
</ul>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">So the work-in-progress concerns the distributed user \
registry. The idea would be to maintain the registry in shared memory, meaning it'd \
be reset (= disappear) when the last application exits, contrary to a file which can \
go stale. This would be simple if QSharedMemory objects could be resized, but \
apparently they cannot, so I'll have to look at other solutions possibly involving OS \
X frameworks (NSData and it's non-objectiveC version CFDataRef or CFMutableDataRef \
might be candidates). Suggestions welcome.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Other work in progress \
concerns a less wheel-reinventing approach that builds on kwalletd and DBus. I don't \
see why the code used in <code style="text-rendering: inherit;color: #4444cc;padding: \
0;white-space: normal;margin: 0;line-height: inherit;">kwallet.cpp</code> wouldn't \
work, but I must still misunderstand its finer details. The present patch contains \
outcommented code that does indeed cause kwalletd to be launched and slots and \
signals to become visible e.g. in <code style="text-rendering: inherit;color: \
#4444cc;padding: 0;white-space: normal;margin: 0;line-height: \
inherit;">qdbusviewer</code>. But they don't work, which in turn makes the whole \
kwallet layer dysfunctional. Here too feedback is welcome on how what I'm missing \
and/or how to get this to work.<br style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;" /> Once kwalletd works, wallet idle \
timeout closing and closing when the last client exits should work out-of-the-box, or \
at least I suppose.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">OS X 10.6.8, kdelibs 4.14.1 git/master, KDE/MacPorts \
4.12.5 .<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;" /> Once finalised, all changes should port easily to \
KF5's kwallet_mac.cpp .</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdeui/util/kwallet.h <span style="color: grey">(d7f703f)</span></li>
<li>kdeui/util/kwallet_mac.cpp <span style="color: grey">(8344ebb)</span></li>
<li>kdeui/util/qosxkeychain.h <span style="color: grey">(d0934e6)</span></li>
<li>kdeui/util/qosxkeychain.cpp <span style="color: grey">(7cb9a22)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120202/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============2051624370754647280==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic