[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Using Gerrit for code review in KDE
From:       Eike Hein <hein () kde ! org>
Date:       2014-09-13 21:05:48
Message-ID: 5414B1AC.2000909 () kde ! org
[Download RAW message or body]



On 13.09.2014 22:50, Sven Brauch wrote:
> That's my opinion as well. It would be nice to have an explicit way to
> differentiate the "I think this patch is okay, but I'm not very
> familiar with the code you changed" (+1) and "I'm confident this patch
> is fine" (+2) cases, and I think everyone with a KDE dev account is
> capable of deciding which one to select by himself when reviewing,
> without a technical restriction on what one can do.

Yeah, that's something I'm OK with too. Maybe we can even
adapt the UI to use strings like Sven proposes?


> Greetings!

Cheers,
Eike
[prev in list] [next in list] [prev in thread] [next in thread]