[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Using Gerrit for code review in KDE
From:       Sven Brauch <svenbrauch () googlemail ! com>
Date:       2014-09-13 20:50:46
Message-ID: CAE_ay6ks6dh3HGGvm7Wa-i1Fo0P=DYaBRwHeGpSnYcVdXWJm4w () mail ! gmail ! com
[Download RAW message or body]

> Everyone with a KDE developer account should in principle have
> the right to give a +2. One should only use it when appropriate though, i.e.
> when one is the maintainer of a given piece of code or when the patch is
> simple enough so that one feels safe to give the other the ship-it.
That's my opinion as well. It would be nice to have an explicit way to
differentiate the "I think this patch is okay, but I'm not very
familiar with the code you changed" (+1) and "I'm confident this patch
is fine" (+2) cases, and I think everyone with a KDE dev account is
capable of deciding which one to select by himself when reviewing,
without a technical restriction on what one can do.

Greetings!
[prev in list] [next in list] [prev in thread] [next in thread]