[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 119363: Port kde-baseapps to use docbook 4.5
From: "Luigi Toscano" <luigi.toscano () tiscali ! it>
Date: 2014-09-04 21:35:28
Message-ID: 20140904213528.11808.18237 () probe ! kde ! org
[Download RAW message or body]
--===============0602533436004416129==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On Aug. 23, 2014, 6:26 p.m., Scarlett Clark wrote:
> > I had to use this patch to get the frameworks branch to build while packaging for \
> > Kubuntu. Anyway we can get this pushed to at least frameworks branch?
>
> Marko Käning wrote:
> I suggested the commit to frameworks to Luigi back then, but he had some arguments \
> against it at the time. Let's see what he thinks now, as I don't want to override \
> him there.
> Luigi Toscano wrote:
> I don't find the discussion but I think I wrote something on the line of: let's see \
> if it can be made working without this, because, if kdelibs4support is installed, \
> this should work. Scarlett, can you please confirm that it does not compile even if \
> kdelibs4support is installed in the buildroot? Could you please paste the error?
> Luigi Toscano wrote:
> To be clear: I'm not against pushing this, you can commit it if no other solutions \
> works and it's the expected step anyway for a complete porting (without \
> kdelibs4support). My point is that the backward compatibility should work; if not, \
> I spent quite some time working on nothing.
> Scarlett Clark wrote:
> http://goo.gl/mLRi02 I pasted my build depends and my failed build.
Sotty, I totally missed this comment! I think you miss kdelibs4support in the build \
dependencies; with that package installed, compilation should work.
- Luigi
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119363/#review65099
-----------------------------------------------------------
On Aug. 24, 2014, 6:33 p.m., Marko Käning wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119363/
> -----------------------------------------------------------
>
> (Updated Aug. 24, 2014, 6:33 p.m.)
>
>
> Review request for KDE Base Apps, Luigi Toscano and Nicolás Alvarez.
>
>
> Repository: kde-baseapps
>
>
> Description
> -------
>
> This suggests to upgrade the docbook DTD from 4.2 to 4.5.
>
> ---
>
> There is still an open issue here:
>
> Spaces in DATA_INSTALL_DIR need to be handled properly, so that the path in the DTD \
> file
> /Library/Application\ Support/kf5/kdoctools/customization/dtd/kdex.dtd
>
> is correctly set, i.e. using "%20" instead of a space.
>
>
> Diffs
> -----
>
> doc/konqueror/index.docbook a1f8565404be0289b51af37df1687e0911a01fe5
> dolphin/docs/index.docbook 5fe85f5d130e3723af556fb02b53970206d1c765
> kdepasswd/docs/index.docbook 2ecef470ac8a9384b7aeb16f123f834d040ee375
> kfind/docs/index.docbook d46dfa4138991a356eec32a7043a883150eb81c2
> kfind/docs/man-kfind.1.docbook ef2eb3b9fb1ed1a84ae33fa631b0295a029444e0
>
> Diff: https://git.reviewboard.kde.org/r/119363/diff/
>
>
> Testing
> -------
>
> Builds/installs fine (if one doesn't use any white-space in DATA_INSTALL_DIR path)
>
>
> Thanks,
>
> Marko Käning
>
>
--===============0602533436004416129==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119363/">https://git.reviewboard.kde.org/r/119363/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On August 23rd, 2014, 6:26 p.m. CEST, <b>Scarlett \
Clark</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I had to use this patch to get the frameworks branch \
to build while packaging for Kubuntu. Anyway we can get this pushed to at least \
frameworks branch?</p></pre> </blockquote>
<p>On August 24th, 2014, 5:59 p.m. CEST, <b>Marko Käning</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
suggested the commit to frameworks to Luigi back then, but he had some arguments \
against it at the time.<br style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;" /> Let's see what he thinks now, as I \
don't want to override him there.</p></pre> </blockquote>
<p>On August 24th, 2014, 6:09 p.m. CEST, <b>Luigi Toscano</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
don't find the discussion but I think I wrote something on the line of: let's see if \
it can be made working without this, because, if kdelibs4support is installed, this \
should work. Scarlett, can you please confirm that it does not compile even if \
kdelibs4support is installed in the buildroot? Could you please paste the \
error?</p></pre> </blockquote>
<p>On August 24th, 2014, 6:11 p.m. CEST, <b>Luigi Toscano</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">To be \
clear: I'm not against pushing this, you can commit it if no other solutions works \
and it's the expected step anyway for a complete porting (without kdelibs4support). \
My point is that the backward compatibility should work; if not, I spent quite some \
time working on nothing.</p></pre> </blockquote>
<p>On August 25th, 2014, 7:12 p.m. CEST, <b>Scarlett Clark</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">http://goo.gl/mLRi02 I pasted my build depends and my failed \
build.</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Sotty, I totally missed this comment! I think you miss kdelibs4support in \
the build dependencies; with that package installed, compilation should \
work.</p></pre> <br />
<p>- Luigi</p>
<br />
<p>On August 24th, 2014, 6:33 p.m. CEST, Marko Käning wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Base Apps, Luigi Toscano and Nicolás Alvarez.</div>
<div>By Marko Käning.</div>
<p style="color: grey;"><i>Updated Aug. 24, 2014, 6:33 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-baseapps
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This suggests to upgrade the docbook DTD from 4.2 to \
4.5.</p> <hr style="text-rendering: inherit;margin: 0;padding: 0;white-space: \
normal;border: 1px solid #ddd;line-height: inherit;" /> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">There \
is still an open issue here:</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Spaces in DATA_INSTALL_DIR need to be \
handled properly, so that the path in the DTD file</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div \
class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%"><span \
style="color: #666666">/</span>Library<span style="color: \
#666666">/</span>Application<span style="border: 1px solid #FF0000">\</span> \
Support<span style="color: #666666">/</span>kf5<span style="color: \
#666666">/</span>kdoctools<span style="color: #666666">/</span>customization<span \
style="color: #666666">/</span>dtd<span style="color: #666666">/</span>kdex.dtd \
</pre></div> </p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">is correctly set, i.e. using "%20" instead of a \
space.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Builds/installs fine (if one doesn't use any \
white-space in DATA_INSTALL_DIR path) </p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>doc/konqueror/index.docbook <span style="color: \
grey">(a1f8565404be0289b51af37df1687e0911a01fe5)</span></li>
<li>dolphin/docs/index.docbook <span style="color: \
grey">(5fe85f5d130e3723af556fb02b53970206d1c765)</span></li>
<li>kdepasswd/docs/index.docbook <span style="color: \
grey">(2ecef470ac8a9384b7aeb16f123f834d040ee375)</span></li>
<li>kfind/docs/index.docbook <span style="color: \
grey">(d46dfa4138991a356eec32a7043a883150eb81c2)</span></li>
<li>kfind/docs/man-kfind.1.docbook <span style="color: \
grey">(ef2eb3b9fb1ed1a84ae33fa631b0295a029444e0)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119363/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============0602533436004416129==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic