[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 119372: Fix Bug 337486 - Should not permit moving of read-only folder to a differ
From: Thomas_Lübking <thomas.luebking () gmail ! com>
Date: 2014-07-21 11:08:16
Message-ID: 20140721110816.14616.14517 () probe ! kde ! org
[Download RAW message or body]
--===============2777872139232453813==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On Juli 20, 2014, 9:21 vorm., Thomas Lübking wrote:
> > lib/konq/konq_operations.cpp, line 479
> > <https://git.reviewboard.kde.org/r/119372/diff/2/?file=291313#file291313line479>
> >
> > is there any guarantee that all urls in lst are in the same directory?
>
> Arjun Ak wrote:
> what?
you're shortcutting the for loop if _any_ iterated element is in a read only \
directory. Unless there's some outer guarantee that _all_ elements are in the same \
directory, you're omitting elements randomly depending on their position in the list \
(ie. once a file is not movable for that reason)
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119372/#review62729
-----------------------------------------------------------
On Juli 20, 2014, 8 vorm., Arjun Ak wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119372/
> -----------------------------------------------------------
>
> (Updated Juli 20, 2014, 8 vorm.)
>
>
> Review request for KDE Base Apps.
>
>
> Bugs: 337486
> http://bugs.kde.org/show_bug.cgi?id=337486
>
>
> Repository: kde-baseapps
>
>
> Description
> -------
>
> Fixes Bug 337486
>
>
> Diffs
> -----
>
> lib/konq/konq_operations.cpp 220a90a
>
> Diff: https://git.reviewboard.kde.org/r/119372/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Arjun Ak
>
>
--===============2777872139232453813==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119372/">https://git.reviewboard.kde.org/r/119372/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On Juli 20th, 2014, 9:21 vorm. UTC, <b>Thomas \
Lübking</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/119372/diff/2/?file=291313#file291313line479" \
style="color: black; font-weight: bold; text-decoration: \
underline;">lib/konq/konq_operations.cpp</a> <span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
KonqOperations::doDropFileCopy()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">479</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="k">break</span><span class="p">;</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">is \
there any guarantee that all urls in lst are in the same directory?</p></pre> \
</blockquote>
<p>On Juli 21st, 2014, 8:40 vorm. UTC, <b>Arjun Ak</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">what?</p></pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">you're shortcutting the for loop if <em style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">any</em> iterated \
element is in a read only directory.<br style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;" /> Unless there's some \
outer guarantee that <em style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;">all</em> elements are in the same \
directory, you're omitting elements randomly depending on their position in the list \
(ie. once a file is not movable for that reason)</p></pre> <br />
<p>- Thomas</p>
<br />
<p>On Juli 20th, 2014, 8 vorm. UTC, Arjun Ak wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Base Apps.</div>
<div>By Arjun Ak.</div>
<p style="color: grey;"><i>Updated Juli 20, 2014, 8 vorm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=337486">337486</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-baseapps
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Fixes Bug 337486</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>lib/konq/konq_operations.cpp <span style="color: grey">(220a90a)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119372/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============2777872139232453813==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic