--===============2777872139232453813== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit > On Juli 20, 2014, 9:21 vorm., Thomas Lübking wrote: > > lib/konq/konq_operations.cpp, line 479 > > > > > > is there any guarantee that all urls in lst are in the same directory? > > Arjun Ak wrote: > what? you're shortcutting the for loop if _any_ iterated element is in a read only directory. Unless there's some outer guarantee that _all_ elements are in the same directory, you're omitting elements randomly depending on their position in the list (ie. once a file is not movable for that reason) - Thomas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119372/#review62729 ----------------------------------------------------------- On Juli 20, 2014, 8 vorm., Arjun Ak wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119372/ > ----------------------------------------------------------- > > (Updated Juli 20, 2014, 8 vorm.) > > > Review request for KDE Base Apps. > > > Bugs: 337486 > http://bugs.kde.org/show_bug.cgi?id=337486 > > > Repository: kde-baseapps > > > Description > ------- > > Fixes Bug 337486 > > > Diffs > ----- > > lib/konq/konq_operations.cpp 220a90a > > Diff: https://git.reviewboard.kde.org/r/119372/diff/ > > > Testing > ------- > > > Thanks, > > Arjun Ak > > --===============2777872139232453813== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 8bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119372/

On Juli 20th, 2014, 9:21 vorm. UTC, Thomas Lübking wrote:
lib/konq/konq_operations.cpp (Diff revision 2)
void KonqOperations::doDropFileCopy()
479
                    break;
is there any guarantee that all urls in lst are in the same directory?
On Juli 21st, 2014, 8:40 vorm. UTC, Arjun Ak wrote:
what?

you're shortcutting the for loop if any iterated element is in a read only directory.
Unless there's some outer guarantee that all elements are in the same directory, you're omitting elements randomly depending on their position in the list (ie. once a file is not movable for that reason)

- Thomas

On Juli 20th, 2014, 8 vorm. UTC, Arjun Ak wrote:

Review request for KDE Base Apps.

By Arjun Ak.

Updated Juli 20, 2014, 8 vorm.

Bugs: 337486

Repository: kde-baseapps

Description

Fixes Bug 337486

Diffs

lib/konq/konq_operations.cpp (220a90a)

--===============2777872139232453813==--