[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 116481: Calculate remaining battery lifetime considering ALL installed batteries
From: "Christoph Feck" <christoph () maxiom ! de>
Date: 2014-05-04 17:16:54
Message-ID: 20140504171654.20771.45626 () probe ! kde ! org
[Download RAW message or body]
> On March 2, 2014, 12:03 a.m., Kai Uwe Broulik wrote:
> > Thanks for looking into this, I have a few code-styling related issues, see \
> > below.
> > In the future I want to get rid of all of this, especially the magic ints instead \
> > of enums, and move that stuff to Solid - where it's already sort-of duplicated - \
> > and especially provide charge/discharge time reporting for individual batteries.
What is the status of this review? From what I see, Joschi resolved all raised \
issues.
- Christoph
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116481/#review51546
-----------------------------------------------------------
On Feb. 28, 2014, 1:53 p.m., Joschi Brauchle wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116481/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2014, 1:53 p.m.)
>
>
> Review request for kde-workspace and Kai Uwe Broulik.
>
>
> Bugs: https://bugs.kde.org/show_bug.cgi?id=253453
> http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=253453
>
>
> Repository: kde-workspace
>
>
> Description
> -------
>
> Currently powerdevil uses the "time-to-empty" property provided by upower to add up \
> battery life for all installed batteries. Unfortunately, upower 0.9.x does not \
> provide a "time-to-empty" for fully charged batteries. Hence, the remaining battery \
> lifetime displayed by powerdevil considers only batteries which are currently being \
> discharged and ignores all fully charged batteries.
> The proposed patch is taken from upower 0.99.x and sums up the total energy \
> available in all installed batteries (discharging and charged) and divides it by \
> the current total discharge rate over all batteries (this is for lifetime, \
> similarly for charge time).
>
> Diffs
> -----
>
> a/powerdevil/daemon/backends/upower/powerdevilupowerbackend.cpp eae5436
>
> Diff: https://git.reviewboard.kde.org/r/116481/diff/
>
>
> Testing
> -------
>
> Tested with KDE 4.11.6 on Thinkpad T440s with
> - two batteries installed
> - one battery installed
>
>
> Thanks,
>
> Joschi Brauchle
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/116481/">https://git.reviewboard.kde.org/r/116481/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On March 2nd, 2014, 12:03 a.m. UTC, <b>Kai Uwe \
Broulik</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Thanks for looking into this, I have a few code-styling related issues, \
see below.
In the future I want to get rid of all of this, especially the magic ints instead of \
enums, and move that stuff to Solid - where it's already sort-of duplicated - and \
especially provide charge/discharge time reporting for individual batteries.</pre> \
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">What is the status of \
this review? From what I see, Joschi resolved all raised issues.</pre> <br />
<p>- Christoph</p>
<br />
<p>On February 28th, 2014, 1:53 p.m. UTC, Joschi Brauchle wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kde-workspace and Kai Uwe Broulik.</div>
<div>By Joschi Brauchle.</div>
<p style="color: grey;"><i>Updated Feb. 28, 2014, 1:53 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=253453">https://bugs.kde.org/show_bug.cgi?id=253453</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Currently powerdevil uses the "time-to-empty" property \
provided by upower to add up battery life for all installed batteries. \
Unfortunately, upower 0.9.x does not provide a "time-to-empty" for fully \
charged batteries. Hence, the remaining battery lifetime displayed by powerdevil \
considers only batteries which are currently being discharged and ignores all fully \
charged batteries.
The proposed patch is taken from upower 0.99.x and sums up the total energy available \
in all installed batteries (discharging and charged) and divides it by the current \
total discharge rate over all batteries (this is for lifetime, similarly for charge \
time).</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested with KDE 4.11.6 on Thinkpad T440s with
- two batteries installed
- one battery installed</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>a/powerdevil/daemon/backends/upower/powerdevilupowerbackend.cpp <span \
style="color: grey">(eae5436)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/116481/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic