[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request 116951: Fix KDBusServiceStarter::findServiceFor() not returning error string
From:       "David Jarvie" <djarvie () kde ! org>
Date:       2014-04-14 11:48:51
Message-ID: 20140414114851.11396.74372 () probe ! kde ! org
[Download RAW message or body]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116951/
-----------------------------------------------------------

(Updated April 14, 2014, 11:48 a.m.)


Review request for kdelibs.


Changes
-------

Fix indentation.

Note to self: when working on systems with different editor settings, check \
whitespace settings ;)


Repository: kdelibs


Description
-------

When KDBusServiceStarter::findServiceFor() fails to start the requested service after \
it is found to not be running, it does not return the error string. This patch fixes \
that and makes it behave as in the apidox.


Diffs (updated)
-----

  kio/kio/kdbusservicestarter.cpp 90624fb 

Diff: https://git.reviewboard.kde.org/r/116951/diff/


Testing
-------

Tested this scenario, and it now returns the error string.


Thanks,

David Jarvie


[Attachment #3 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/116951/">https://git.reviewboard.kde.org/r/116951/</a>
  </td>
    </tr>
   </table>
   <br />




<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kdelibs.</div>
<div>By David Jarvie.</div>


<p style="color: grey;"><i>Updated April 14, 2014, 11:48 a.m.</i></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Fix indentation.

Note to self: when working on systems with different editor settings, check \
whitespace settings ;)</pre>  </td>
 </tr>
</table>







<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">When KDBusServiceStarter::findServiceFor() fails to start the requested \
service after it is found to not be running, it does not return the error string. \
This patch fixes that and makes it behave as in the apidox.</pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested this scenario, and it now returns the error string.</pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>kio/kio/kdbusservicestarter.cpp <span style="color: grey">(90624fb)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/116951/diff/" style="margin-left: \
3em;">View Diff</a></p>







  </td>
 </tr>
</table>




  </div>
 </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic