From kde-core-devel Mon Apr 14 11:48:51 2014 From: "David Jarvie" Date: Mon, 14 Apr 2014 11:48:51 +0000 To: kde-core-devel Subject: Re: Review Request 116951: Fix KDBusServiceStarter::findServiceFor() not returning error string Message-Id: <20140414114851.11396.74372 () probe ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-core-devel&m=139747617824898 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============1155309885153471924==" --===============1155309885153471924== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116951/ ----------------------------------------------------------- (Updated April 14, 2014, 11:48 a.m.) Review request for kdelibs. Changes ------- Fix indentation. Note to self: when working on systems with different editor settings, check whitespace settings ;) Repository: kdelibs Description ------- When KDBusServiceStarter::findServiceFor() fails to start the requested service after it is found to not be running, it does not return the error string. This patch fixes that and makes it behave as in the apidox. Diffs (updated) ----- kio/kio/kdbusservicestarter.cpp 90624fb Diff: https://git.reviewboard.kde.org/r/116951/diff/ Testing ------- Tested this scenario, and it now returns the error string. Thanks, David Jarvie --===============1155309885153471924== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116951/

Review request for kdelibs.

By David Jarvie.

Updated April 14, 2014, 11:48 a.m.

Changes

Fix indentation.

Note to self: when working on systems with different editor settings, check whitespace settings ;)

Repository: kdelibs

Description

When KDBusServiceStarter::findServiceFor() fails to start the requested service after it is found to not be running, it does not return the error string. This patch fixes that and makes it behave as in the apidox.

Testing

Tested this scenario, and it now returns the error string.

Diffs (updated)

kio/kio/kdbusservicestarter.cpp (90624fb)

View Diff

--===============1155309885153471924==--