[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 117090: add version to libmolletnetwork
From: "Aleix Pol Gonzalez" <aleixpol () kde ! org>
Date: 2014-03-29 2:12:11
Message-ID: 20140329021211.10710.38878 () probe ! kde ! org
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117090/#review54522
-----------------------------------------------------------
Ship it!
Ship It!
- Aleix Pol Gonzalez
On March 26, 2014, 4:10 p.m., Jonathan Riddell wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117090/
> -----------------------------------------------------------
>
> (Updated March 26, 2014, 4:10 p.m.)
>
>
> Review request for KDE Runtime and Aleix Pol Gonzalez.
>
>
> Repository: kde-runtime
>
>
> Description
> -------
>
> add soversion to libmolletnetwork, currently it installs as \
> libmolletnetwork.so.SOVERSION which can't be right. used a simple static version \
> number as inspired by libksysguard in kde-workspace
>
> Diffs
> -----
>
> kioslave/network/network/CMakeLists.txt ad72048
>
> Diff: https://git.reviewboard.kde.org/r/117090/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jonathan Riddell
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117090/">https://git.reviewboard.kde.org/r/117090/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<p>- Aleix Pol Gonzalez</p>
<br />
<p>On March 26th, 2014, 4:10 p.m. UTC, Jonathan Riddell wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Runtime and Aleix Pol Gonzalez.</div>
<div>By Jonathan Riddell.</div>
<p style="color: grey;"><i>Updated March 26, 2014, 4:10 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-runtime
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">add soversion to libmolletnetwork, currently it installs as \
libmolletnetwork.so.SOVERSION which can't be right. used a simple static version \
number as inspired by libksysguard in kde-workspace</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kioslave/network/network/CMakeLists.txt <span style="color: \
grey">(ad72048)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117090/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic