'Review Request 116808: RFC for fixing bug 332132'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Review Request 116808: RFC for fixing bug 332132
From:       "Paul Chavent" <paul.chavent () fnac ! net>
Date:       2014-03-15 12:47:47
Message-ID: 20140315124747.7362.9037 () probe ! kde ! org
[Download RAW message or body]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116808/
-----------------------------------------------------------

Review request for kdelibs.


Repository: kdelibs


Description
-------

This patch aims to fix the bug 332132 (in the kde bug tracker).

It delay the deletion of animation states thanks to QSharedPointer.


Diffs
-----

  kio/kio/delegateanimationhandler.cpp 9055a98 
  kio/kio/delegateanimationhandler_p.h bd26006 
  kio/kio/kfileitemdelegate.cpp 50cc3b6 

Diff: https://git.reviewboard.kde.org/r/116808/diff/


Testing
-------


Thanks,

Paul Chavent


[Attachment #3 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/116808/">https://git.reviewboard.kde.org/r/116808/</a>
  </td>
    </tr>
   </table>
   <br />




<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kdelibs.</div>
<div>By Paul Chavent.</div>










<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch aims to fix the bug 332132 (in the kde bug tracker).

It delay the deletion of animation states thanks to QSharedPointer.

</pre>
  </td>
 </tr>
</table>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kio/kio/delegateanimationhandler.cpp <span style="color: \
grey">(9055a98)</span></li>

 <li>kio/kio/delegateanimationhandler_p.h <span style="color: \
grey">(bd26006)</span></li>

 <li>kio/kio/kfileitemdelegate.cpp <span style="color: grey">(50cc3b6)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/116808/diff/" style="margin-left: \
3em;">View Diff</a></p>







  </td>
 </tr>
</table>




  </div>
 </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread]
Configure | About | News | Add a list | Sponsored by KoreLogic