[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 116784: Fix incorrect use of KDateTime.toTime_t in kio_http
From: "David Jarvie" <djarvie () kde ! org>
Date: 2014-03-14 17:04:47
Message-ID: 20140314170447.2591.93011 () probe ! kde ! org
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116784/#review52940
-----------------------------------------------------------
kioslave/http/http.cpp
<https://git.reviewboard.kde.org/r/116784/#comment37258>
Need to convert to UTC first, since it will produce the wrong value if it's in \
some random time zone: dt.toUtc().dateTime()
- David Jarvie
On March 13, 2014, 12:49 p.m., Dawit Alemayehu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116784/
> -----------------------------------------------------------
>
> (Updated March 13, 2014, 12:49 p.m.)
>
>
> Review request for kdelibs, Andreas Hartmetz and David Faure.
>
>
> Repository: kdelibs
>
>
> Description
> -------
>
> The attached patch does the following:
>
> - It corrects a mistake in assumption that KDateTime.toTime_t() will return -1 for \
> invalidate dates. It does not. The result is an overflow which is interpreted in \
> kio_http as a timestamp in the distant future which obviously is wrong. See \
> https://bugs.kde.org/show_bug.cgi?id=331774 for example. This assumption also \
> affects the timestamp variables used for cache management.
> - It converts cache management timestamp variables to 64 bits so they can \
> accomodates dates beyond Feb 7, 2106.
>
> Diffs
> -----
>
> kioslave/http/http.h dd85622
> kioslave/http/http.cpp e4f1eba
>
> Diff: https://git.reviewboard.kde.org/r/116784/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dawit Alemayehu
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/116784/">https://git.reviewboard.kde.org/r/116784/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/116784/diff/1/?file=253643#file253643line304" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kioslave/http/http.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">304</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">return</span> <span class="p">(</span><span class="n">dt</span><span \
class="p">.</span><span class="n">isValid</span><span class="p">()</span> <span \
class="o">?</span> <span class="p">(</span><span class="n">dt</span><span \
class="p">.</span><span class="n">dateTime</span><span class="p">().</span><span \
class="n">toMSecsSinceEpoch</span><span class="p">()</span><span \
class="o">/</span><span class="mi">1000</span><span class="p">)</span> <span \
class="o">:</span> <span class="o">-</span><span class="mi">1</span><span \
class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Need to \
convert to UTC first, since it will produce the wrong value if it's in some \
random time zone: dt.toUtc().dateTime()</pre>
</div>
<br />
<p>- David Jarvie</p>
<br />
<p>On March 13th, 2014, 12:49 p.m. UTC, Dawit Alemayehu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs, Andreas Hartmetz and David Faure.</div>
<div>By Dawit Alemayehu.</div>
<p style="color: grey;"><i>Updated March 13, 2014, 12:49 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The attached patch does the following:
- It corrects a mistake in assumption that KDateTime.toTime_t() will return -1 for \
invalidate dates. It does not. The result is an overflow which is interpreted in \
kio_http as a timestamp in the distant future which obviously is wrong. See \
https://bugs.kde.org/show_bug.cgi?id=331774 for example. This assumption also affects \
the timestamp variables used for cache management.
- It converts cache management timestamp variables to 64 bits so they can accomodates \
dates beyond Feb 7, 2106.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kioslave/http/http.h <span style="color: grey">(dd85622)</span></li>
<li>kioslave/http/http.cpp <span style="color: grey">(e4f1eba)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/116784/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic