'Re: Review Request 116097: No longer use strlcpy in kstartupconfig'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request 116097: No longer use strlcpy in kstartupconfig
From:       "Rolf Eike Beer" <kde () opensource ! sf-tec ! de>
Date:       2014-02-26 20:32:34
Message-ID: 20140226203234.31541.37795 () probe ! kde ! org
[Download RAW message or body]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116097/#review50982
-----------------------------------------------------------


When you start poking at this code, why not kill the entire fopen/fgets/fixed size buffer stuff and \
replace it with std streams or something like that?

- Rolf Eike Beer


On Feb. 26, 2014, 6:11 p.m., Alexander Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116097/
> -----------------------------------------------------------
> 
> (Updated Feb. 26, 2014, 6:11 p.m.)
> 
> 
> Review request for kde-workspace.
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> -------
> 
> No longer use strlcpy in kstartupconfig
> 
> This means we no longer need to find libbsd on Linux.
> kstartupconfig is now uses std::string instead of pure C strings, but
> the performance difference should be minimal (and it is less error-prone).
> 
> 
> Diffs
> -----
> 
> CMakeLists.txt bce3cd1de65b8420a859c342db981919965071ba 
> cmake/modules/FindLibBSD.cmake 6383083023cdbfbeffcab0cef98f48102e593d38 
> kstartupconfig/CMakeLists.txt ceebd6a65af4cdaa717cfb0dcff5097121cf48d9 
> kstartupconfig/kstartupconfig.c d8e65f48a75dad49fe6c585f89260c2a6d483809 
> 
> Diff: https://git.reviewboard.kde.org/r/116097/diff/
> 
> 
> Testing
> -------
> 
> compiles
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
> 


[Attachment #3 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/116097/">https://git.reviewboard.kde.org/r/116097/</a>
     </td>
    </tr>
   </table>
   <br />





 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: \
-o-pre-wrap; word-wrap: break-word;">When you start poking at this code, why not kill the entire \
fopen/fgets/fixed size buffer stuff and replace it with std streams or something like that?</pre>  <br />









<p>- Rolf Eike Beer</p>


<br />
<p>On February 26th, 2014, 6:11 p.m. UTC, Alexander Richardson wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black solid;">  <tr>
  <td>

<div>Review request for kde-workspace.</div>
<div>By Alexander Richardson.</div>


<p style="color: grey;"><i>Updated Feb. 26, 2014, 6:11 p.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">No longer use strlcpy in kstartupconfig

This means we no longer need to find libbsd on Linux.
kstartupconfig is now uses std::string instead of pure C strings, but
the performance difference should be minimal (and it is less error-prone).</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">compiles</pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>CMakeLists.txt <span style="color: grey">(bce3cd1de65b8420a859c342db981919965071ba)</span></li>

 <li>cmake/modules/FindLibBSD.cmake <span style="color: \
grey">(6383083023cdbfbeffcab0cef98f48102e593d38)</span></li>

 <li>kstartupconfig/CMakeLists.txt <span style="color: \
grey">(ceebd6a65af4cdaa717cfb0dcff5097121cf48d9)</span></li>

 <li>kstartupconfig/kstartupconfig.c <span style="color: \
grey">(d8e65f48a75dad49fe6c585f89260c2a6d483809)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/116097/diff/" style="margin-left: 3em;">View Diff</a></p>







  </td>
 </tr>
</table>








  </div>
 </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread]
Configure | About | News | Add a list | Sponsored by KoreLogic