[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 113866: kio bookmarks: Only iterate over element nodes in findToolbar()
From: Stefan_Brüns <stefan.bruens () rwth-aachen ! de>
Date: 2014-01-11 16:34:09
Message-ID: 20140111163409.28498.54423 () probe ! kde ! org
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/113866/
-----------------------------------------------------------
(Updated Jan. 11, 2014, 4:34 p.m.)
Status
------
This change has been marked as submitted.
Review request for kdelibs and Frank Reininghaus.
Bugs: 320006
http://bugs.kde.org/show_bug.cgi?id=320006
Repository: kdelibs
Description
-------
Only iterate over element nodes, and filter on <folder> tag.
findFirstChild/nextSibling might return a node which is not an QDomElement. toElement \
will return NULL and accessing it will crash.
Possible fix for 320006
Diffs
-----
kio/bookmarks/kbookmark.cc 8459a02
Diff: https://git.reviewboard.kde.org/r/113866/diff/
Testing
-------
None
Thanks,
Stefan Brüns
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/113866/">https://git.reviewboard.kde.org/r/113866/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;"> <tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs and Frank Reininghaus.</div>
<div>By Stefan Brüns.</div>
<p style="color: grey;"><i>Updated Jan. 11, 2014, 4:34 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=320006">320006</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Only iterate over element nodes, and filter on <folder> tag.
findFirstChild/nextSibling might return a node which is not an QDomElement. toElement \
will return NULL and accessing it will crash.
Possible fix for 320006</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">None</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kio/bookmarks/kbookmark.cc <span style="color: grey">(8459a02)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/113866/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic