From kde-core-devel Sat Jan 11 16:34:09 2014 From: =?utf-8?q?Stefan_Br=C3=BCns?= Date: Sat, 11 Jan 2014 16:34:09 +0000 To: kde-core-devel Subject: Re: Review Request 113866: kio bookmarks: Only iterate over element nodes in findToolbar() Message-Id: <20140111163409.28498.54423 () probe ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-core-devel&m=138945808202442 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============6750553370627008419==" --===============6750553370627008419== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/113866/ ----------------------------------------------------------- (Updated Jan. 11, 2014, 4:34 p.m.) Status ------ This change has been marked as submitted. Review request for kdelibs and Frank Reininghaus. Bugs: 320006 http://bugs.kde.org/show_bug.cgi?id=320006 Repository: kdelibs Description ------- Only iterate over element nodes, and filter on tag. findFirstChild/nextSibling might return a node which is not an QDomElement. toElement will return NULL and accessing it will crash. Possible fix for 320006 Diffs ----- kio/bookmarks/kbookmark.cc 8459a02 Diff: https://git.reviewboard.kde.org/r/113866/diff/ Testing ------- None Thanks, Stefan Brüns --===============6750553370627008419== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/113866/

This change has been marked as submitted.

Review request for kdelibs and Frank Reininghaus.

By Stefan Brüns.

Updated Jan. 11, 2014, 4:34 p.m.

Bugs: 320006

Repository: kdelibs

Description

Only iterate over element nodes, and filter on <folder> tag.

findFirstChild/nextSibling might return a node which is not an QDomElement. toElement will return NULL and accessing it will crash.

Possible fix for 320006

Testing

None

Diffs

kio/bookmarks/kbookmark.cc (8459a02)

View Diff

--===============6750553370627008419==--