'Re: Review Request 113607: Install all user agent desktop files'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request 113607: Install all user agent desktop files
From:       "Maarten De Meyer" <de.meyer.maarten () gmail ! com>
Date:       2014-01-11 16:08:49
Message-ID: 20140111160849.7621.91971 () probe ! kde ! org
[Download RAW message or body]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/113607/#review47194
-----------------------------------------------------------


Bump?
This is a very trivial change. Should I just commit this kind of stuff in the future \
instead of letting it rot for weeks?

- Maarten De Meyer


On Nov. 4, 2013, 5:19 p.m., Maarten De Meyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/113607/
> -----------------------------------------------------------
> 
> (Updated Nov. 4, 2013, 5:19 p.m.)
> 
> 
> Review request for KDE Base Apps.
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> Currently each user agent file has to be listed separately in the CMakeLists.txt \
> file. The latest commit that added new files forgot to list them so they are never \
> installed. Fixed properly by GLOBING for *.desktop
> 
> 
> Diffs
> -----
> 
> konqueror/settings/kio/uasproviders/CMakeLists.txt 6c49f42 
> 
> Diff: https://git.reviewboard.kde.org/r/113607/diff/
> 
> 
> Testing
> -------
> 
> Builds.
> Nobody gets left behind!
> 
> 
> Thanks,
> 
> Maarten De Meyer
> 
> 


[Attachment #3 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/113607/">https://git.reviewboard.kde.org/r/113607/</a>
  </td>
    </tr>
   </table>
   <br />





 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Bump? This is a very \
trivial change. Should I just commit this kind of stuff in the future instead of \
letting it rot for weeks?</pre>  <br />









<p>- Maarten De Meyer</p>


<br />
<p>On November 4th, 2013, 5:19 p.m. UTC, Maarten De Meyer wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDE Base Apps.</div>
<div>By Maarten De Meyer.</div>


<p style="color: grey;"><i>Updated Nov. 4, 2013, 5:19 p.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-baseapps
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Currently each user agent file has to be listed separately in the \
CMakeLists.txt file. The latest commit that added new files forgot to list them so \
they are never installed. Fixed properly by GLOBING for *.desktop</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Builds. Nobody gets left behind!</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>konqueror/settings/kio/uasproviders/CMakeLists.txt <span style="color: \
grey">(6c49f42)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/113607/diff/" style="margin-left: \
3em;">View Diff</a></p>







  </td>
 </tr>
</table>








  </div>
 </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread]
Configure | About | News | Add a list | Sponsored by KoreLogic