From kde-core-devel Sat Jan 11 16:08:49 2014 From: "Maarten De Meyer" Date: Sat, 11 Jan 2014 16:08:49 +0000 To: kde-core-devel Subject: Re: Review Request 113607: Install all user agent desktop files Message-Id: <20140111160849.7621.91971 () probe ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-core-devel&m=138945654002129 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============0290863798099599836==" --===============0290863798099599836== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/113607/#review47194 ----------------------------------------------------------- Bump? This is a very trivial change. Should I just commit this kind of stuff in the future instead of letting it rot for weeks? - Maarten De Meyer On Nov. 4, 2013, 5:19 p.m., Maarten De Meyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/113607/ > ----------------------------------------------------------- > > (Updated Nov. 4, 2013, 5:19 p.m.) > > > Review request for KDE Base Apps. > > > Repository: kde-baseapps > > > Description > ------- > > Currently each user agent file has to be listed separately in the CMakeLists.txt file. The latest commit that added new files forgot to list them so they are never installed. > Fixed properly by GLOBING for *.desktop > > > Diffs > ----- > > konqueror/settings/kio/uasproviders/CMakeLists.txt 6c49f42 > > Diff: https://git.reviewboard.kde.org/r/113607/diff/ > > > Testing > ------- > > Builds. > Nobody gets left behind! > > > Thanks, > > Maarten De Meyer > > --===============0290863798099599836== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/113607/ 

Bump?
This is a very trivial change. Should I just commit this kind of stuff in the future instead of letting it rot for weeks?

- Maarten De Meyer


On November 4th, 2013, 5:19 p.m. UTC, Maarten De Meyer wrote:

Review request for KDE Base Apps.
By Maarten De Meyer.

Updated Nov. 4, 2013, 5:19 p.m.

Repository: kde-baseapps

Description 

Currently each user agent file has to be listed separately in the CMakeLists.txt file. The latest commit that added new files forgot to list them so they are never installed.
Fixed properly by GLOBING for *.desktop

Testing 

Builds.
Nobody gets left behind!

Diffs

  • konqueror/settings/kio/uasproviders/CMakeLists.txt (6c49f42)

View Diff
--===============0290863798099599836==--