[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Review Request 114519: fix endless loop in KLineEdit->setSqueezedText()
From:       "Axel Arnold" <arnolda747 () gmail ! com>
Date:       2013-12-17 15:15:17
Message-ID: 20131217151517.16884.39167 () vidsolbach ! de
[Download RAW message or body]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114519/
-----------------------------------------------------------

Review request for kdelibs.


Bugs: 328263
    http://bugs.kde.org/show_bug.cgi?id=328263


Repository: kdelibs


Description
-------

If KLineEdit has squeezed text enabled, but the widget has still zero width, \
KLineEdit::setSqueezedText() can go into an endless loop trying to remove more than \
all letters from the string. This patch fixes both this underrun and the \
corresponding possible overrun if the squeezed text is too small. The underrun is \
responsible for endless loops in digikam, see the corresponding bug report.


Diffs
-----

  kdeui/widgets/klineedit.cpp 2193ef2969d49ad602e66da7776feda4b7595b13 

Diff: http://git.reviewboard.kde.org/r/114519/diff/


Testing
-------


Thanks,

Axel Arnold


[Attachment #3 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/114519/">http://git.reviewboard.kde.org/r/114519/</a>
  </td>
    </tr>
   </table>
   <br />




<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kdelibs.</div>
<div>By Axel Arnold.</div>








<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>


 <a href="http://bugs.kde.org/show_bug.cgi?id=328263">328263</a>


</div>



<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">If KLineEdit has squeezed text enabled, but the widget has still zero \
width, KLineEdit::setSqueezedText() can go into an endless loop trying to remove more \
than all letters from the string. This patch fixes both this underrun and the \
corresponding possible overrun if the squeezed text is too small. The underrun is \
responsible for endless loops in digikam, see the corresponding bug report. </pre>
  </td>
 </tr>
</table>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kdeui/widgets/klineedit.cpp <span style="color: \
grey">(2193ef2969d49ad602e66da7776feda4b7595b13)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/114519/diff/" style="margin-left: \
3em;">View Diff</a></p>







  </td>
 </tr>
</table>




  </div>
 </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic