From kde-core-devel Tue Dec 17 15:15:17 2013 From: "Axel Arnold" Date: Tue, 17 Dec 2013 15:15:17 +0000 To: kde-core-devel Subject: Review Request 114519: fix endless loop in KLineEdit->setSqueezedText() Message-Id: <20131217151517.16884.39167 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-core-devel&m=138729334103607 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============3245933068307819603==" --===============3245933068307819603== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114519/ ----------------------------------------------------------- Review request for kdelibs. Bugs: 328263 http://bugs.kde.org/show_bug.cgi?id=328263 Repository: kdelibs Description ------- If KLineEdit has squeezed text enabled, but the widget has still zero width, KLineEdit::setSqueezedText() can go into an endless loop trying to remove more than all letters from the string. This patch fixes both this underrun and the corresponding possible overrun if the squeezed text is too small. The underrun is responsible for endless loops in digikam, see the corresponding bug report. Diffs ----- kdeui/widgets/klineedit.cpp 2193ef2969d49ad602e66da7776feda4b7595b13 Diff: http://git.reviewboard.kde.org/r/114519/diff/ Testing ------- Thanks, Axel Arnold --===============3245933068307819603== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114519/

Review request for kdelibs.

By Axel Arnold.

Bugs: 328263

Repository: kdelibs

Description

If KLineEdit has squeezed text enabled, but the widget has still zero width, KLineEdit::setSqueezedText() can go into an endless loop trying to remove more than all letters from the string. This patch fixes both this underrun and the corresponding possible overrun if the squeezed text is too small. The underrun is responsible for endless loops in digikam, see the corresponding bug report.

Diffs

kdeui/widgets/klineedit.cpp (2193ef2969d49ad602e66da7776feda4b7595b13)

View Diff

--===============3245933068307819603==--