'Re: Review Request 114368: Fix freeze of plasma-desktop after resume using smb/nfs mounts in /etc/mt'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request 114368: Fix freeze of plasma-desktop after resume using smb/nfs mounts in /etc/mt
From:       "Ralf Habacker" <ralf.habacker () freenet ! de>
Date:       2013-12-09 17:16:56
Message-ID: 20131209171656.1507.54697 () vidsolbach ! de
[Download RAW message or body]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114368/
-----------------------------------------------------------

(Updated Dec. 9, 2013, 6:16 p.m.)


Review request for kdelibs.


Bugs: 184062
    http://bugs.kde.org/show_bug.cgi?id=184062


Repository: kdelibs


Description
-------

KMountPoint::List::findByPath() calls realpath for each given path.
When using NetworkManager controlled connections on resume these calls
are blocked, because the connection is not ready at this state.
The function returns from the blocking state after a very long timeout (several minutes) . 
    
This patch avoids blocking realpath calls for pathes directly located in
/etc/mtab. As far as I can see there is no need to call realpath for this cases.


Diffs
-----

  kdecore/io/kmountpoint.cpp d06d796 

Diff: http://git.reviewboard.kde.org/r/114368/diff/


Testing
-------

opensuse 12.2 x86_64, KDE 4.11.2


Thanks,

Ralf Habacker


[Attachment #3 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/114368/">http://git.reviewboard.kde.org/r/114368/</a>
  </td>
    </tr>
   </table>
   <br />




<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kdelibs.</div>
<div>By Ralf Habacker.</div>


<p style="color: grey;"><i>Updated Dec. 9, 2013, 6:16 p.m.</i></p>







<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>


 <a href="http://bugs.kde.org/show_bug.cgi?id=184062">184062</a>


</div>



<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">KMountPoint::List::findByPath() calls realpath for each given path. When \
using NetworkManager controlled connections on resume these calls are blocked, \
because the connection is not ready at this state. The function returns from the \
blocking state after a very long timeout (several minutes) .   
This patch avoids blocking realpath calls for pathes directly located in
/etc/mtab. As far as I can see there is no need to call realpath for this cases.
</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">opensuse 12.2 x86_64, KDE 4.11.2</pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kdecore/io/kmountpoint.cpp <span style="color: grey">(d06d796)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/114368/diff/" style="margin-left: \
3em;">View Diff</a></p>







  </td>
 </tr>
</table>




  </div>
 </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread]
Configure | About | News | Add a list | Sponsored by KoreLogic