From kde-core-devel Mon Dec 09 17:16:56 2013 From: "Ralf Habacker" Date: Mon, 09 Dec 2013 17:16:56 +0000 To: kde-core-devel Subject: Re: Review Request 114368: Fix freeze of plasma-desktop after resume using smb/nfs mounts in /etc/mt Message-Id: <20131209171656.1507.54697 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-core-devel&m=138660944006861 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============7979920193284295624==" --===============7979920193284295624== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114368/ ----------------------------------------------------------- (Updated Dec. 9, 2013, 6:16 p.m.) Review request for kdelibs. Bugs: 184062 http://bugs.kde.org/show_bug.cgi?id=184062 Repository: kdelibs Description ------- KMountPoint::List::findByPath() calls realpath for each given path. When using NetworkManager controlled connections on resume these calls are blocked, because the connection is not ready at this state. The function returns from the blocking state after a very long timeout (several minutes) . This patch avoids blocking realpath calls for pathes directly located in /etc/mtab. As far as I can see there is no need to call realpath for this cases. Diffs ----- kdecore/io/kmountpoint.cpp d06d796 Diff: http://git.reviewboard.kde.org/r/114368/diff/ Testing ------- opensuse 12.2 x86_64, KDE 4.11.2 Thanks, Ralf Habacker --===============7979920193284295624== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114368/

Review request for kdelibs.

By Ralf Habacker.

Updated Dec. 9, 2013, 6:16 p.m.

Bugs: 184062

Repository: kdelibs

Description

KMountPoint::List::findByPath() calls realpath for each given path.
When using NetworkManager controlled connections on resume these calls
are blocked, because the connection is not ready at this state.
The function returns from the blocking state after a very long timeout (several minutes) . 
    
This patch avoids blocking realpath calls for pathes directly located in
/etc/mtab. As far as I can see there is no need to call realpath for this cases.

Testing

opensuse 12.2 x86_64, KDE 4.11.2

Diffs

kdecore/io/kmountpoint.cpp (d06d796)

View Diff

--===============7979920193284295624==--