[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: KMountPoint::probablySlow and cifs mount points
From:       Albert Astals Cid <aacid () kde ! org>
Date:       2013-11-24 21:10:46
Message-ID: 1795221.eGVgKA6BYN () xps
[Download RAW message or body]

El Diumenge, 24 de novembre de 2013, a les 19:55:28, Ivan Čukić va escriure:
> > > and adding cifs to the list of mounttypes that are "probablySlow"?
> > 
> > It's not my place to object since the code isn't mine. Yet i do
> 
> Whether it is a good to use probablySlow in okular is one question. The
> other one is whether cifs should be in the probablySlow category.

Right

> 
> From my point of view, it does belong to the same group as nfs, samba and
> similar. So, since the method 'probablySlow' exists, ant it works the way it
> currently does, I'd say yes.

I'll create a review request for this.

> It is called *probably*Slow exactly because we don't do any actual speed
> tests, but we are guessing it can be noticeably slower than a local file
> system.
> 
> As for whether it is fitting to use it in this case, or whether the method
> itself could be replaced by something smarter, I have no opinion.

Thanks,
  Albert

> 
> 
> Cheerio,
> Ivan

[prev in list] [next in list] [prev in thread] [next in thread]