This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113503/ 

Any chance to see Stephen's comments addressed or this patch is abandoned?

- Kevin Ottens


On October 30th, 2013, 10:08 a.m. UTC, Sune Vuorela wrote:

Review request for KDE Frameworks, kdelibs and Stephen Kelly.
By Sune Vuorela.

Updated Oct. 30, 2013, 10:08 a.m.

Repository: kdelibs

Description 

Make dbus dependency optional in JobWidgets

Many don't have dbus available on all platforms, especially windows, but JobWidgets is very much useful without it.

Testing 

build tested on windows without dbus. not yet tested on other platforms

Diffs

  • tier2/kjobwidgets/CMakeLists.txt (ca53024)
  • tier2/kjobwidgets/src/CMakeLists.txt (0a575a6)
  • tier2/kjobwidgets/src/config-kjobwidgets.h.cmake (35b64a2)
  • tier2/kjobwidgets/tests/kjobtrackerstest.cpp (7a61407)

View Diff