[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Review Request 113175: Always use an external viewer application to view files
From: "Sven Brauch" <svenbrauch () googlemail ! com>
Date: 2013-10-08 15:08:09
Message-ID: 20131008150809.19437.50973 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113175/
-----------------------------------------------------------
Review request for KDE Base Apps.
Repository: ark
Description
-------
This patch makes ark always use an external viewer application instead of using the \
clunky internal preview thing. The internal viewer would just embed a plain kpart \
into a window, but without providing any of the XMLGUI or whatever from that part. \
Thus, when you for example clicked a PDF, you couldn't print it. The advantages of \
the internal viewer are imo overall quite questionable, and are far outweighted by \
its disadvantages.
Plus, it removes code ;)
Diffs
-----
part/arkviewer.cpp 053cd1c0502d3bb88895dc8d3653eaea9e6c3c83
Diff: http://git.reviewboard.kde.org/r/113175/diff/
Testing
-------
Clicking files opens them in the default application, as it should.
Thanks,
Sven Brauch
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113175/">http://git.reviewboard.kde.org/r/113175/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Base Apps.</div>
<div>By Sven Brauch.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ark
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch makes ark always use an external viewer application instead \
of using the clunky internal preview thing. The internal viewer would just embed a \
plain kpart into a window, but without providing any of the XMLGUI or whatever from \
that part. Thus, when you for example clicked a PDF, you couldn't print it. The \
advantages of the internal viewer are imo overall quite questionable, and are far \
outweighted by its disadvantages.
Plus, it removes code ;)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Clicking files opens them in the default application, as it \
should.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>part/arkviewer.cpp <span style="color: \
grey">(053cd1c0502d3bb88895dc8d3653eaea9e6c3c83)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113175/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic