From kde-core-devel Tue Oct 08 15:08:09 2013 From: "Sven Brauch" Date: Tue, 08 Oct 2013 15:08:09 +0000 To: kde-core-devel Subject: Review Request 113175: Always use an external viewer application to view files Message-Id: <20131008150809.19437.50973 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-core-devel&m=138124491331628 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============3534891069789988943==" --===============3534891069789988943== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113175/ ----------------------------------------------------------- Review request for KDE Base Apps. Repository: ark Description ------- This patch makes ark always use an external viewer application instead of using the clunky internal preview thing. The internal viewer would just embed a plain kpart into a window, but without providing any of the XMLGUI or whatever from that part. Thus, when you for example clicked a PDF, you couldn't print it. The advantages of the internal viewer are imo overall quite questionable, and are far outweighted by its disadvantages. Plus, it removes code ;) Diffs ----- part/arkviewer.cpp 053cd1c0502d3bb88895dc8d3653eaea9e6c3c83 Diff: http://git.reviewboard.kde.org/r/113175/diff/ Testing ------- Clicking files opens them in the default application, as it should. Thanks, Sven Brauch --===============3534891069789988943== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113175/

Review request for KDE Base Apps.
By Sven Brauch.
Repository: ark

Description 

This patch makes ark always use an external viewer application instead of using the clunky internal preview thing. The internal viewer would just embed a plain kpart into a window, but without providing any of the XMLGUI or whatever from that part. Thus, when you for example clicked a PDF, you couldn't print it. The advantages of the internal viewer are imo overall quite questionable, and are far outweighted by its disadvantages.

Plus, it removes code ;)

Testing 

Clicking files opens them in the default application, as it should.

Diffs

  • part/arkviewer.cpp (053cd1c0502d3bb88895dc8d3653eaea9e6c3c83)

View Diff
--===============3534891069789988943==--