[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Broken tests in kdelibs due to kio change
From:       Dawit A <adawit () kde ! org>
Date:       2013-08-03 17:16:03
Message-ID: CALa28R7RaK7SNSxejTmx2e6aDDDoX529i5dWxVxUKr4TjLC3nQ () mail ! gmail ! com
[Download RAW message or body]

Hmm... I fail to see how my changes break those unit tests. Perhaps
changing fileundomanager from NoGui to Gui did it? Anyhow, I will try to
look into it.


On Sat, Aug 3, 2013 at 10:25 AM, Albert Astals Cid <aacid@kde.org> wrote:

> Dawit, kdelibs people, there are 4 tests that broke in
> very-close-to-release
> 4.11 branch with a change from yesterday to kio.
>
> http://build.kde.org/view/KDE%20SC%20stable/job/kdelibs_stable/735/
>
> Can you guys please have a look and fix those failing tests?
>
> Also please please please make sure you either run the tests before
> commiting
> changes so late in the release cycle *and* even if you run them please
> check
> with jenkins to see his opinion on your changes :)
>
> Cheers,
>   Albert
>

[Attachment #3 (text/html)]

<div dir="ltr">Hmm... I fail to see how my changes break those unit tests. Perhaps \
changing fileundomanager from NoGui to Gui did it? Anyhow, I will try to look into \
it.<div class="gmail_extra"><br><br><div class="gmail_quote">


On Sat, Aug 3, 2013 at 10:25 AM, Albert Astals Cid <span dir="ltr">&lt;<a \
href="mailto:aacid@kde.org" target="_blank">aacid@kde.org</a>&gt;</span> \
wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px \
#ccc solid;padding-left:1ex">


Dawit, kdelibs people, there are 4 tests that broke in very-close-to-release<br>
4.11 branch with a change from yesterday to kio.<br>
<br>
<a href="http://build.kde.org/view/KDE%20SC%20stable/job/kdelibs_stable/735/" \
target="_blank">http://build.kde.org/view/KDE%20SC%20stable/job/kdelibs_stable/735/</a><br>
 <br>
Can you guys please have a look and fix those failing tests?<br>
<br>
Also please please please make sure you either run the tests before commiting<br>
changes so late in the release cycle *and* even if you run them please check<br>
with jenkins to see his opinion on your changes :)<br>
<br>
Cheers,<br>
   Albert<br>
</blockquote></div><br></div></div>



[prev in list] [next in list] [prev in thread] [next in thread]